Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 916893003: Add test_runner hook to dump drag image. (Closed)

Created:
5 years, 10 months ago by jackhou1
Modified:
5 years, 10 months ago
Reviewers:
tkent
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, chrome-apps-syd-reviews_chromium.org, Justin Novosad
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test_runner hook to dump drag image. This is a second attempt at: https://codereview.chromium.org/904833004/ which caused flakiness in pixel tests and was reverted here: https://codereview.chromium.org/919273002/ This CL merges the fix from: https://codereview.chromium.org/918313003/ It also handles the case where dumpDragImage is called but no drag occurs by dumping a 1x1 empty transparent image. This is used by: https://codereview.chromium.org/886323005/ BUG=451759, 458077 Committed: https://crrev.com/656fc851d598be035f826deb1b1b05f227ef5865 Cr-Commit-Position: refs/heads/master@{#316194}

Patch Set 1 #

Patch Set 2 : Check flag instead of drag_image_. Handle isNull case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M content/shell/renderer/test_runner/test_runner.h View 3 chunks +10 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 6 chunks +17 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 3 chunks +3 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 3 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jackhou1
tkent, please take a look.
5 years, 10 months ago (2015-02-13 04:57:27 UTC) #2
tkent
lgtm
5 years, 10 months ago (2015-02-13 08:27:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916893003/20001
5 years, 10 months ago (2015-02-13 08:28:11 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 09:04:25 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 09:05:18 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/656fc851d598be035f826deb1b1b05f227ef5865
Cr-Commit-Position: refs/heads/master@{#316194}

Powered by Google App Engine
This is Rietveld 408576698