Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2371)

Unified Diff: chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h

Issue 916833005: [Mac] Use a custom view to implement colored app windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync and rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h
diff --git a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h
index b8aef3d69fc3a8307df9290958c192582491edee..da61ae216099063531bb1ddbd201662c47e7ed97 100644
--- a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h
+++ b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h
@@ -43,6 +43,16 @@ class SkRegion;
@end
+// A view that paints a solid color. Used to change the title bar background.
+@interface TitlebarBackgroundView : NSView {
tapted 2015/02/19 03:11:02 forward declare this? i.e. just `@class TitlebarBa
jackhou1 2015/02/19 04:28:58 Done.
+ @private
+ base::scoped_nsobject<NSColor> color_;
+ base::scoped_nsobject<NSColor> inactiveColor_;
+}
+- (void)setColor:(NSColor*)color
+ inactiveColor:(NSColor*)inactiveColor;
tapted 2015/02/19 03:11:02 nit: minimum 4 space indent (colons are allowed to
jackhou1 2015/02/19 04:28:58 Done.
+@end
+
// Cocoa bridge to AppWindow.
class NativeAppWindowCocoa : public extensions::NativeAppWindow,
public content::WebContentsObserver {
@@ -206,6 +216,7 @@ class NativeAppWindowCocoa : public extensions::NativeAppWindow,
SkColor inactive_frame_color_;
base::scoped_nsobject<NativeAppWindowController> window_controller_;
+ base::scoped_nsobject<TitlebarBackgroundView> titlebar_background_view_;
// For system drag, the whole window is draggable and the non-draggable areas
// have to been explicitly excluded.

Powered by Google App Engine
This is Rietveld 408576698