Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 9168037: Add a trybot config that runs chrome_frame_tests.exe. This runs on a separate bot since these tes... (Closed)

Created:
8 years, 11 months ago by robertshield
Modified:
8 years, 11 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, cmp, nsylvain+cc_chromium.org, grt (UTC plus 2), erikwright (departed), ananta
Visibility:
Public.

Description

Add a trybot config that runs chrome_frame_tests.exe. This runs on a separate bot since these tests currently take a while (5+ minutes) to run. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117215

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M .gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.tryserver.chromium/master.cfg View 2 chunks +9 lines, -0 lines 0 comments Download
M masters/master.tryserver.chromium/slaves.cfg View 1 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
robertshield
8 years, 11 months ago (2012-01-11 04:59:56 UTC) #1
M-A Ruel
lgtm with nits http://codereview.chromium.org/9168037/diff/4001/masters/master.tryserver.chromium/slaves.cfg File masters/master.tryserver.chromium/slaves.cfg (right): http://codereview.chromium.org/9168037/diff/4001/masters/master.tryserver.chromium/slaves.cfg#newcode148 masters/master.tryserver.chromium/slaves.cfg:148: cf_slave = [ please use chromeframe_slave ...
8 years, 11 months ago (2012-01-11 14:26:30 UTC) #2
robertshield
Also added .gitignore entry. PTAL http://codereview.chromium.org/9168037/diff/4001/masters/master.tryserver.chromium/slaves.cfg File masters/master.tryserver.chromium/slaves.cfg (right): http://codereview.chromium.org/9168037/diff/4001/masters/master.tryserver.chromium/slaves.cfg#newcode148 masters/master.tryserver.chromium/slaves.cfg:148: cf_slave = [ On ...
8 years, 11 months ago (2012-01-11 14:34:18 UTC) #3
M-A Ruel
lgtm
8 years, 11 months ago (2012-01-11 14:39:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/9168037/8001
8 years, 11 months ago (2012-01-11 14:39:53 UTC) #5
commit-bot: I haz the power
8 years, 11 months ago (2012-01-11 14:41:49 UTC) #6
Change committed as 117215

Powered by Google App Engine
This is Rietveld 408576698