Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 916803002: skip failing test on arm64 (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

skip failing test on arm64 LOG=N BUG=v8:3884 Committed: https://crrev.com/81544f28596df5f89ad03d56bfdeabad0b4ba2e1 Cr-Commit-Position: refs/heads/master@{#26582}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
Michael Achenbach
https://codereview.chromium.org/916803002/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/916803002/diff/1/test/mjsunit/mjsunit.status#newcode307 test/mjsunit/mjsunit.status:307: Check also for gc_stress == True as the test ...
5 years, 10 months ago (2015-02-11 14:10:39 UTC) #2
Michael Achenbach
otherwise lgtm with that last comment
5 years, 10 months ago (2015-02-11 14:11:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916803002/20001
5 years, 10 months ago (2015-02-11 14:16:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-11 14:35:59 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/81544f28596df5f89ad03d56bfdeabad0b4ba2e1 Cr-Commit-Position: refs/heads/master@{#26582}
5 years, 10 months ago (2015-02-11 14:36:19 UTC) #8
Michael Achenbach
https://codereview.chromium.org/916803002/diff/20001/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/916803002/diff/20001/test/mjsunit/mjsunit.status#newcode306 test/mjsunit/mjsunit.status:306: 'regress/regress-builtinbust-7.js': [PASS, ['gc_stress == True', SKIP]], meh - I ...
5 years, 10 months ago (2015-02-11 17:10:03 UTC) #9
dcarney
5 years, 10 months ago (2015-02-11 18:14:39 UTC) #10
Message was sent while issue was closed. 
On 2015/02/11 17:10:03, Michael Achenbach (OOO) wrote:
>
https://codereview.chromium.org/916803002/diff/20001/test/mjsunit/mjsunit.status
> File test/mjsunit/mjsunit.status (right):
> 
>
https://codereview.chromium.org/916803002/diff/20001/test/mjsunit/mjsunit.sta...
> test/mjsunit/mjsunit.status:306: 'regress/regress-builtinbust-7.js': [PASS,
> ['gc_stress == True', SKIP]],
> meh - I didn't look close enough. There shouldn't be a .js extension. Like
that
> the test isn't recognized...

it's okay, i'll revert anyway as i think the fix is in r26593 - just waiting for
the waterfall to verify

Powered by Google App Engine
This is Rietveld 408576698