chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h - Issue 916783003: Restrict salient image size before storing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h

Issue 916783003: Restrict salient image size before storing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use pixel instead of dp Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.cc » ('j') | chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h

diff --git a/chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h b/chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h

index 680e8dc36cdfea838362ab0b04744f5e7a1b45c1..0df85e3b67b577579d1f2d00ced68df801f272d0 100644

--- a/chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h

+++ b/chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h

@@ -24,6 +24,8 @@ class BookmarkImageServiceAndroid : public BookmarkImageService {

public:

explicit BookmarkImageServiceAndroid(content::BrowserContext* browserContext);

+ ~BookmarkImageServiceAndroid() override;

void RetrieveSalientImage(const GURL& page_url,

const GURL& image_url,

const std::string& referrer,

@@ -48,9 +50,12 @@ class BookmarkImageServiceAndroid : public BookmarkImageService {

bool update_bookmark,

const base::Value* result);

+ gfx::Image ResizeImage(gfx::Image image) override;

content::BrowserContext* browser_context_;

// The script injected in a page to extract image urls.

base::string16 script_;

+ scoped_ptr<gfx::Size> max_size_;

noyau (Ping after 24h) 2015/02/13 09:57:42 Need comment. And why is this a scoped ptr and not

Ian Wen 2015/02/13 22:51:24 Changed to gfx::Size.

class BitmapFetcherHandler : private chrome::BitmapFetcherDelegate {

public: