Allowing WhispernetClient to be used during initialization

Allowing WhispernetClient to be used during initialization

Committed: https://crrev.com/69a960210633bb95599c531965d783b91fe70956
Cr-Commit-Position: refs/heads/master@{#316409}

[Charlie, 2015-02-11 21:43:55]

ckehoe@chromium.org changed reviewers:
+ rkc@chromium.org, xiyuan@chromium.org

[Charlie, 2015-02-11 21:43:56]

This CL simplifies the initialization model for Whispernet. It seems that
Whispernet can handle initialization more easily than upstream code like
CopresenceManager, by just queueing events rather than sending them to NaCl.

After the audio modem changes go in, we should clean up the copresence component
to not worry about Whispernet initialization. With these changes, the modem
won't have to worry about it either.

https://codereview.chromium.org/916763005/diff/1/chrome/browser/copresence/ch...
File chrome/browser/copresence/chrome_whispernet_client.cc (left):

https://codereview.chromium.org/916763005/diff/1/chrome/browser/copresence/ch...
chrome/browser/copresence/chrome_whispernet_client.cc:219:
AudioConfiguration(GetDefaultAudioConfig());
Audio configuration can now be queued just like any other event. Thus the
wrapper doesn't have to call the init callback twice. This simplifies the tests
also.

[xiyuan, 2015-02-12 15:44:38]

lgtm

[Charlie, 2015-02-12 20:06:03]

New patchsets have been uploaded after l-g-t-m from xiyuan@chromium.org

[Charlie, 2015-02-12 20:08:16]

On 2015/02/12 15:44:38, xiyuan wrote:
> lgtm

Adding a little bit of the cleanup that this enables. Rahul, can you take a look
before I check this in?

[Charlie, 2015-02-15 06:15:53]

The CQ bit was checked by ckehoe@chromium.org

[commit-bot: I haz the power, 2015-02-15 06:16:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/916763005/60001

[commit-bot: I haz the power, 2015-02-15 06:52:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-15 06:52:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Charlie, 2015-02-15 07:07:32]

The CQ bit was checked by ckehoe@chromium.org

[commit-bot: I haz the power, 2015-02-15 07:07:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/916763005/60001

[commit-bot: I haz the power, 2015-02-15 08:07:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-15 08:08:01]

Patchset 4 (id:??) landed as
https://crrev.com/69a960210633bb95599c531965d783b91fe70956
Cr-Commit-Position: refs/heads/master@{#316409}