Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 916763003: Fix Chromium build (Closed)

Created:
5 years, 10 months ago by robertphillips
Modified:
5 years, 10 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/MatrixClipCollapseTest.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M tools/filtermain.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916763003/1
5 years, 10 months ago (2015-02-11 19:07:35 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/2052) Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 10 months ago (2015-02-11 19:08:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916763003/20001
5 years, 10 months ago (2015-02-11 19:25:35 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/f5e89c8f685ac8a5c4d117e087b4111d613106db
5 years, 10 months ago (2015-02-11 19:38:48 UTC) #8
robertphillips
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/915153002/ by robertphillips@google.com. ...
5 years, 10 months ago (2015-02-11 21:05:40 UTC) #9
robertphillips
5 years, 10 months ago (2015-02-11 21:17:36 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/916963002/ by robertphillips@google.com.

The reason for reverting is: Chrome.

Powered by Google App Engine
This is Rietveld 408576698