Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: cc/resources/gpu_tile_task_worker_pool.cc

Issue 916723002: cc: Add threaded GPU rasterization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Hold context lock when GpuTTWP accesses worker context. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/gpu_tile_task_worker_pool.h" 5 #include "cc/resources/gpu_tile_task_worker_pool.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/trace_event/trace_event.h" 9 #include "base/trace_event/trace_event.h"
10 #include "cc/resources/gpu_rasterizer.h"
10 #include "cc/resources/raster_buffer.h" 11 #include "cc/resources/raster_buffer.h"
11 #include "cc/resources/raster_source.h" 12 #include "cc/resources/raster_source.h"
12 #include "cc/resources/resource.h" 13 #include "cc/resources/resource.h"
13 #include "cc/resources/scoped_gpu_raster.h" 14 #include "cc/resources/scoped_gpu_raster.h"
14 #include "gpu/command_buffer/client/gles2_interface.h" 15 #include "gpu/command_buffer/client/gles2_interface.h"
15 #include "third_party/skia/include/core/SkMultiPictureDraw.h" 16 #include "third_party/skia/include/core/SkMultiPictureDraw.h"
16 #include "third_party/skia/include/core/SkPictureRecorder.h" 17 #include "third_party/skia/include/core/SkPictureRecorder.h"
17 #include "third_party/skia/include/core/SkSurface.h" 18 #include "third_party/skia/include/core/SkSurface.h"
18 #include "third_party/skia/include/gpu/GrContext.h" 19 #include "third_party/skia/include/gpu/GrContext.h"
19 20
20 namespace cc { 21 namespace cc {
21 namespace { 22 namespace {
22 23
23 class RasterBufferImpl : public RasterBuffer { 24 class RasterBufferImpl : public RasterBuffer {
24 public: 25 public:
25 RasterBufferImpl() {} 26 RasterBufferImpl(GpuRasterizer* rasterizer, const Resource* resource)
27 : rasterizer_(rasterizer),
28 lock_(rasterizer->resource_provider(), resource->id()),
29 resource_(resource) {}
26 30
27 // Overridden from RasterBuffer: 31 // Overridden from RasterBuffer:
28 void Playback(const RasterSource* raster_source, 32 void Playback(const RasterSource* raster_source,
29 const gfx::Rect& rect, 33 const gfx::Rect& rect,
30 float scale) override { 34 float scale) override {
31 // Don't do anything. 35 TRACE_EVENT0("cc", "RasterBufferImpl::Playback");
36
37 ContextProvider* context_provider = rasterizer_->resource_provider()
38 ->output_surface()
39 ->worker_context_provider();
40
41 // We must hold the context lock while accessing the context on the
42 // worker thread.
43 base::AutoLock scoped_lock(*context_provider->GetLock());
vmiura 2015/02/13 19:52:34 jbauman's patch for ContextProvider::GetLock() lan
44
45 // Rasterize source into resource.
46 rasterizer_->RasterizeSource(true, &lock_, raster_source, rect, scale);
47
48 // Barrier to sync worker context output to cc context.
49 context_provider->ContextGL()->OrderingBarrierCHROMIUM();
32 } 50 }
33 51
34 private: 52 private:
53 GpuRasterizer* rasterizer_;
54 ResourceProvider::ScopedWriteLockGr lock_;
55 const Resource* resource_;
56
35 DISALLOW_COPY_AND_ASSIGN(RasterBufferImpl); 57 DISALLOW_COPY_AND_ASSIGN(RasterBufferImpl);
36 }; 58 };
37 59
38 } // namespace 60 } // namespace
61
39 // static 62 // static
40 scoped_ptr<TileTaskWorkerPool> GpuTileTaskWorkerPool::Create( 63 scoped_ptr<TileTaskWorkerPool> GpuTileTaskWorkerPool::Create(
41 base::SequencedTaskRunner* task_runner, 64 base::SequencedTaskRunner* task_runner,
42 TaskGraphRunner* task_graph_runner, 65 TaskGraphRunner* task_graph_runner,
43 ResourceProvider* resource_provider) { 66 GpuRasterizer* rasterizer) {
44 return make_scoped_ptr<TileTaskWorkerPool>( 67 return make_scoped_ptr<TileTaskWorkerPool>(
45 new GpuTileTaskWorkerPool( 68 new GpuTileTaskWorkerPool(task_runner, task_graph_runner, rasterizer));
46 task_runner, task_graph_runner, resource_provider));
47 } 69 }
48 70
49 // TODO(hendrikw): This class should be removed. See crbug.com/444938.
50 GpuTileTaskWorkerPool::GpuTileTaskWorkerPool( 71 GpuTileTaskWorkerPool::GpuTileTaskWorkerPool(
51 base::SequencedTaskRunner* task_runner, 72 base::SequencedTaskRunner* task_runner,
52 TaskGraphRunner* task_graph_runner, 73 TaskGraphRunner* task_graph_runner,
53 ResourceProvider* resource_provider) 74 GpuRasterizer* rasterizer)
54 : task_runner_(task_runner), 75 : task_runner_(task_runner),
55 task_graph_runner_(task_graph_runner), 76 task_graph_runner_(task_graph_runner),
56 namespace_token_(task_graph_runner_->GetNamespaceToken()), 77 namespace_token_(task_graph_runner_->GetNamespaceToken()),
57 resource_provider_(resource_provider), 78 rasterizer_(rasterizer),
58 task_set_finished_weak_ptr_factory_(this), 79 task_set_finished_weak_ptr_factory_(this),
59 weak_ptr_factory_(this) { 80 weak_ptr_factory_(this) {
81 // Allow |worker_context_provider| to bind to the worker thread.
82 rasterizer_->resource_provider()
83 ->output_surface()
84 ->worker_context_provider()
85 ->DetachFromThread();
60 } 86 }
61 87
62 GpuTileTaskWorkerPool::~GpuTileTaskWorkerPool() { 88 GpuTileTaskWorkerPool::~GpuTileTaskWorkerPool() {
63 DCHECK_EQ(0u, completed_tasks_.size()); 89 DCHECK_EQ(0u, completed_tasks_.size());
90 // Allow |worker_context_provider| to bind to the cc thread.
91 rasterizer_->resource_provider()
92 ->output_surface()
93 ->worker_context_provider()
94 ->DetachFromThread();
64 } 95 }
65 96
66 TileTaskRunner* GpuTileTaskWorkerPool::AsTileTaskRunner() { 97 TileTaskRunner* GpuTileTaskWorkerPool::AsTileTaskRunner() {
67 return this; 98 return this;
68 } 99 }
69 100
70 void GpuTileTaskWorkerPool::SetClient(TileTaskRunnerClient* client) { 101 void GpuTileTaskWorkerPool::SetClient(TileTaskRunnerClient* client) {
71 client_ = client; 102 client_ = client;
72 } 103 }
73 104
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 InsertNodesForRasterTask(&graph_, task, task->dependencies(), priority++); 153 InsertNodesForRasterTask(&graph_, task, task->dependencies(), priority++);
123 } 154 }
124 155
125 for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set) { 156 for (TaskSet task_set = 0; task_set < kNumberOfTaskSets; ++task_set) {
126 InsertNodeForTask(&graph_, new_task_set_finished_tasks[task_set].get(), 157 InsertNodeForTask(&graph_, new_task_set_finished_tasks[task_set].get(),
127 kTaskSetFinishedTaskPriorityBase + task_set, 158 kTaskSetFinishedTaskPriorityBase + task_set,
128 task_count[task_set]); 159 task_count[task_set]);
129 } 160 }
130 161
131 ScheduleTasksOnOriginThread(this, &graph_); 162 ScheduleTasksOnOriginThread(this, &graph_);
163
164 // Barrier to sync any new resources to the worker context.
165 rasterizer_->resource_provider()
166 ->output_surface()
167 ->context_provider()
168 ->ContextGL()
169 ->OrderingBarrierCHROMIUM();
170
132 task_graph_runner_->ScheduleTasks(namespace_token_, &graph_); 171 task_graph_runner_->ScheduleTasks(namespace_token_, &graph_);
133 172
134 std::copy(new_task_set_finished_tasks, 173 std::copy(new_task_set_finished_tasks,
135 new_task_set_finished_tasks + kNumberOfTaskSets, 174 new_task_set_finished_tasks + kNumberOfTaskSets,
136 task_set_finished_tasks_); 175 task_set_finished_tasks_);
137 } 176 }
138 177
139 void GpuTileTaskWorkerPool::CheckForCompletedTasks() { 178 void GpuTileTaskWorkerPool::CheckForCompletedTasks() {
140 TRACE_EVENT0("cc", "GpuTileTaskWorkerPool::CheckForCompletedTasks"); 179 TRACE_EVENT0("cc", "GpuTileTaskWorkerPool::CheckForCompletedTasks");
141 180
142 task_graph_runner_->CollectCompletedTasks(namespace_token_, 181 task_graph_runner_->CollectCompletedTasks(namespace_token_,
143 &completed_tasks_); 182 &completed_tasks_);
144 CompleteTasks(completed_tasks_); 183 CompleteTasks(completed_tasks_);
145 completed_tasks_.clear(); 184 completed_tasks_.clear();
146 } 185 }
147 186
148 ResourceFormat GpuTileTaskWorkerPool::GetResourceFormat() { 187 ResourceFormat GpuTileTaskWorkerPool::GetResourceFormat() {
149 return resource_provider_->best_texture_format(); 188 return rasterizer_->resource_provider()->best_texture_format();
150 } 189 }
151 190
152 void GpuTileTaskWorkerPool::CompleteTasks(const Task::Vector& tasks) { 191 void GpuTileTaskWorkerPool::CompleteTasks(const Task::Vector& tasks) {
153 for (auto& task : tasks) { 192 for (auto& task : tasks) {
154 RasterTask* raster_task = static_cast<RasterTask*>(task.get()); 193 RasterTask* raster_task = static_cast<RasterTask*>(task.get());
155 194
156 raster_task->WillComplete(); 195 raster_task->WillComplete();
157 raster_task->CompleteOnOriginThread(this); 196 raster_task->CompleteOnOriginThread(this);
158 raster_task->DidComplete(); 197 raster_task->DidComplete();
159 198
160 raster_task->RunReplyOnOriginThread(); 199 raster_task->RunReplyOnOriginThread();
161 } 200 }
162 completed_tasks_.clear(); 201 completed_tasks_.clear();
163 } 202 }
164 203
165 scoped_ptr<RasterBuffer> GpuTileTaskWorkerPool::AcquireBufferForRaster( 204 scoped_ptr<RasterBuffer> GpuTileTaskWorkerPool::AcquireBufferForRaster(
166 const Resource* resource) { 205 const Resource* resource) {
167 return make_scoped_ptr<RasterBuffer>(new RasterBufferImpl()); 206 return make_scoped_ptr<RasterBuffer>(
207 new RasterBufferImpl(rasterizer_, resource));
168 } 208 }
169 209
170 void GpuTileTaskWorkerPool::ReleaseBufferForRaster( 210 void GpuTileTaskWorkerPool::ReleaseBufferForRaster(
171 scoped_ptr<RasterBuffer> buffer) { 211 scoped_ptr<RasterBuffer> buffer) {
172 // Nothing to do here. RasterBufferImpl destructor cleans up after itself. 212 // Nothing to do here. RasterBufferImpl destructor cleans up after itself.
173 } 213 }
174 214
175 void GpuTileTaskWorkerPool::OnTaskSetFinished(TaskSet task_set) { 215 void GpuTileTaskWorkerPool::OnTaskSetFinished(TaskSet task_set) {
176 TRACE_EVENT1("cc", "GpuTileTaskWorkerPool::OnTaskSetFinished", "task_set", 216 TRACE_EVENT1("cc", "GpuTileTaskWorkerPool::OnTaskSetFinished", "task_set",
177 task_set); 217 task_set);
178 218
179 DCHECK(tasks_pending_[task_set]); 219 DCHECK(tasks_pending_[task_set]);
180 tasks_pending_[task_set] = false; 220 tasks_pending_[task_set] = false;
181 client_->DidFinishRunningTileTasks(task_set); 221 client_->DidFinishRunningTileTasks(task_set);
182 } 222 }
183 223
184 } // namespace cc 224 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698