content/browser/site_per_process_browsertest.cc - Issue 916693003: Disable flaky SitePerProcessBrowserTest.CrashSubframe test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 916693003: Disable flaky SitePerProcessBrowserTest.CrashSubframe test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/site_per_process_browsertest.cc

diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc

index f5b509aafd66e3761c64368e42076dfaefb76563..9c9c0f2f05c6805d133c20fe6a0a725a15077d01 100644

--- a/content/browser/site_per_process_browsertest.cc

+++ b/content/browser/site_per_process_browsertest.cc

@@ -577,7 +577,8 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,

// Crash a subframe and ensures its children are cleared from the FrameTree.

// See http://crbug.com/338508.

-IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, CrashSubframe) {

+// TODO(creis): Disabled for flakiness; see http://crbug.com/405582.

+IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, DISABLED_CrashSubframe) {

GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html"));

NavigateToURL(shell(), main_url);

« no previous file with comments | « no previous file | no next file » | no next file with comments »