Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 916563002: add dummy avx file so xcode will build (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add dummy avx file so xcode will build BUG=skia: Committed: https://skia.googlesource.com/skia/+/a0921f2563701d54e4e022de99f2705f4ada8a6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gyp/opts.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A src/opts/SkDummy_opts_AVX.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
reed1
ptal -- fix avx break
5 years, 10 months ago (2015-02-10 21:12:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916563002/1
5 years, 10 months ago (2015-02-10 21:13:11 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-10 21:13:12 UTC) #5
mtklein
lgtm
5 years, 10 months ago (2015-02-10 21:38:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/a0921f2563701d54e4e022de99f2705f4ada8a6e
5 years, 10 months ago (2015-02-10 21:39:18 UTC) #7
mtklein
5 years, 10 months ago (2015-02-11 02:16:29 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/912213002/ by mtklein@google.com.

The reason for reverting is: Going to punt on 16-bit float support for now. 
Can't figure out ARM 64..

Powered by Google App Engine
This is Rietveld 408576698