Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 916543004: [x64] Generate test reg,reg instead of cmp reg,0. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Generate test reg,reg instead of cmp reg,0. The instruction sequence is shorter and saves decoding bandwidth. R=svenpanne@chromium.org Committed: https://crrev.com/a7fb5ed400701b22c455d0ad410bc98b211e5730 Cr-Commit-Position: refs/heads/master@{#26734}

Patch Set 1 #

Patch Set 2 : REBASE. Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 2 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Benedikt Meurer
5 years, 10 months ago (2015-02-18 13:09:23 UTC) #1
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-18 13:09:44 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-18 13:21:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916543004/1
5 years, 10 months ago (2015-02-18 13:22:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/3184)
5 years, 10 months ago (2015-02-18 13:32:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916543004/20001
5 years, 10 months ago (2015-02-19 07:34:50 UTC) #10
Benedikt Meurer
Committed patchset #2 (id:20001) manually as a7fb5ed400701b22c455d0ad410bc98b211e5730 (presubmit successful).
5 years, 10 months ago (2015-02-19 07:45:59 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a7fb5ed400701b22c455d0ad410bc98b211e5730 Cr-Commit-Position: refs/heads/master@{#26734}
5 years, 10 months ago (2015-02-19 07:46:01 UTC) #13
Benedikt Meurer
5 years, 10 months ago (2015-02-19 10:37:29 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/939923003/ by bmeurer@chromium.org.

The reason for reverting is: Tanks some benchmarks (for no obvious reason).

Powered by Google App Engine
This is Rietveld 408576698