Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Side by Side Diff: tools/auto_bisect/bisect_perf_regression.py

Issue 916543002: Add "" as a valid value for --builder_type in bisect_perf_regression.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Chromium auto-bisect tool 6 """Chromium auto-bisect tool
7 7
8 This script bisects a range of commits using binary search. It starts by getting 8 This script bisects a range of commits using binary search. It starts by getting
9 reference values for the specified "good" and "bad" commits. Then, for revisions 9 reference values for the specified "good" and "bad" commits. Then, for revisions
10 in between, it will get builds, run tests and classify intermediate revisions as 10 in between, it will get builds, run tests and classify intermediate revisions as
(...skipping 2623 matching lines...) Expand 10 before | Expand all | Expand 10 after
2634 group.add_argument('--target_arch', default='ia32', 2634 group.add_argument('--target_arch', default='ia32',
2635 dest='target_arch', choices=['ia32', 'x64', 'arm'], 2635 dest='target_arch', choices=['ia32', 'x64', 'arm'],
2636 help='The target build architecture. Choices are "ia32" ' 2636 help='The target build architecture. Choices are "ia32" '
2637 '(default), "x64" or "arm".') 2637 '(default), "x64" or "arm".')
2638 group.add_argument('--target_build_type', default='Release', 2638 group.add_argument('--target_build_type', default='Release',
2639 choices=['Release', 'Debug'], 2639 choices=['Release', 'Debug'],
2640 help='The target build type. Choices are "Release" ' 2640 help='The target build type. Choices are "Release" '
2641 '(default), or "Debug".') 2641 '(default), or "Debug".')
2642 group.add_argument('--builder_type', default=fetch_build.PERF_BUILDER, 2642 group.add_argument('--builder_type', default=fetch_build.PERF_BUILDER,
2643 choices=[fetch_build.PERF_BUILDER, 2643 choices=[fetch_build.PERF_BUILDER,
2644 fetch_build.FULL_BUILDER], 2644 fetch_build.FULL_BUILDER, ''],
2645 help='Type of builder to get build from. This ' 2645 help='Type of builder to get build from. This '
2646 'determines both the bot that builds and the ' 2646 'determines both the bot that builds and the '
2647 'place where archived builds are downloaded from.') 2647 'place where archived builds are downloaded from. '
2648 'For local builds, an empty string can be passed.')
2648 2649
2649 @staticmethod 2650 @staticmethod
2650 def _AddDebugOptionsGroup(parser): 2651 def _AddDebugOptionsGroup(parser):
2651 group = parser.add_argument_group('Debug options') 2652 group = parser.add_argument_group('Debug options')
2652 group.add_argument('--debug_ignore_build', action='store_true', 2653 group.add_argument('--debug_ignore_build', action='store_true',
2653 help='DEBUG: Don\'t perform builds.') 2654 help='DEBUG: Don\'t perform builds.')
2654 group.add_argument('--debug_ignore_sync', action='store_true', 2655 group.add_argument('--debug_ignore_sync', action='store_true',
2655 help='DEBUG: Don\'t perform syncs.') 2656 help='DEBUG: Don\'t perform syncs.')
2656 group.add_argument('--debug_ignore_perf_test', action='store_true', 2657 group.add_argument('--debug_ignore_perf_test', action='store_true',
2657 help='DEBUG: Don\'t perform performance tests.') 2658 help='DEBUG: Don\'t perform performance tests.')
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
2816 # bugs. If you change this, please update the perf dashboard as well. 2817 # bugs. If you change this, please update the perf dashboard as well.
2817 bisect_utils.OutputAnnotationStepStart('Results') 2818 bisect_utils.OutputAnnotationStepStart('Results')
2818 print 'Runtime Error: %s' % e 2819 print 'Runtime Error: %s' % e
2819 if opts.output_buildbot_annotations: 2820 if opts.output_buildbot_annotations:
2820 bisect_utils.OutputAnnotationStepClosed() 2821 bisect_utils.OutputAnnotationStepClosed()
2821 return 1 2822 return 1
2822 2823
2823 2824
2824 if __name__ == '__main__': 2825 if __name__ == '__main__':
2825 sys.exit(main()) 2826 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698