chrome/browser/ui/cocoa/profiles/avatar_button.h - Issue 916523003: Bring up fast user switcher on right-click of the avatar menu on Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/profiles/avatar_button.h

Issue 916523003: Bring up fast user switcher on right-click of the avatar menu on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm ('k') | chrome/browser/ui/cocoa/profiles/avatar_button.mm » ('j') | chrome/browser/ui/cocoa/profiles/avatar_button.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_COCOA_PROFILES_AVATAR_BUTTON_H_

	6 #define CHROME_BROWSER_UI_COCOA_PROFILES_AVATAR_BUTTON_H_

	7

	8 #import <Cocoa/Cocoa.h>

	9

	10 #import "ui/base/cocoa/hover_image_button.h"

	11

	12 // Subclassing HoverImageButton for the sole purpose of letting the Avatar
	Robert Sesek 2015/02/17 18:40:46 Use descriptive comments (http://google-styleguide Use descriptive comments (http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Comm...). E.g., "A subclass of HoverImageButton that sends a target-action on right click." anthonyvd 2015/02/18 00:02:23 Done. Show quoted text On 2015/02/17 18:40:46, Robert Sesek wrote: > Use descriptive comments > (http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Comm...). > > E.g., "A subclass of HoverImageButton that sends a target-action on right > click." Done.
	13 // Button respond to right clicks for fast profile switching

	14 UI_BASE_EXPORT
	Alexei Svitkine (slow) 2015/02/17 16:43:26 This isn't in ui base, so shouldn't need this. This isn't in ui base, so shouldn't need this. anthonyvd 2015/02/18 00:02:23 Done. Show quoted text On 2015/02/17 16:43:26, Alexei Svitkine wrote: > This isn't in ui base, so shouldn't need this. Done.
	15 @interface AvatarButton : HoverImageButton {

	16 SEL rightAction;
	Alexei Svitkine (slow) 2015/02/17 16:43:26 Add @private. Add @private. anthonyvd 2015/02/18 00:02:23 Done. Show quoted text On 2015/02/17 16:43:26, Alexei Svitkine wrote: > Add @private. Done.
	17 }

	18

	19 - (void)setRightAction:(SEL)selector;
	Alexei Svitkine (slow) 2015/02/17 16:43:26 Needs a comment. Needs a comment. anthonyvd 2015/02/18 00:02:24 Done. Show quoted text On 2015/02/17 16:43:26, Alexei Svitkine wrote: > Needs a comment. Done.
	20

	21 @end

	22

	23 #endif //CHROME_BROWSER_UI_COCOA_PROFILES_AVATAR_BUTTON_H_

OLD	NEW