Split installation of system packages and user SDKs.

Split installation of system packages and user SDKs.

This avoids mixing install roles plus simplifies building Chromium on
continuous build systems, where root access is not usually available
nor desired.

BUG=

Committed: https://crrev.com/aeae0b7ce6581e60198858e4c79709e2f2d1ee86
Cr-Commit-Position: refs/heads/master@{#315648}

[lisandrop, 2015-02-10 20:40:37]

lisandrop@google.com changed reviewers:
+ cjhopman@chromium.org

[cjhopman, 2015-02-10 21:08:48]

lgtm

[cjhopman, 2015-02-10 21:09:19]

https://codereview.chromium.org/916473002/diff/1/build/install-android-sdks.sh
File build/install-android-sdks.sh (right):

https://codereview.chromium.org/916473002/diff/1/build/install-android-sdks.s...
build/install-android-sdks.sh:3: # Copyright (c) 2012 The Chromium Authors. All
rights reserved.
nit: update copyright

[lisandrop, 2015-02-10 21:18:59]

The CQ bit was checked by lisandrop@google.com

[commit-bot: I haz the power, 2015-02-10 21:19:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/916473002/1

[commit-bot: I haz the power, 2015-02-10 21:39:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-10 21:40:18]

Patchset 1 (id:??) landed as
https://crrev.com/aeae0b7ce6581e60198858e4c79709e2f2d1ee86
Cr-Commit-Position: refs/heads/master@{#315648}

[lisandrop, 2015-02-10 21:40:28]

https://codereview.chromium.org/916473002/diff/1/build/install-android-sdks.sh
File build/install-android-sdks.sh (right):

https://codereview.chromium.org/916473002/diff/1/build/install-android-sdks.s...
build/install-android-sdks.sh:3: # Copyright (c) 2012 The Chromium Authors. All
rights reserved.
On 2015/02/10 21:09:19, cjhopman wrote:
> nit: update copyright

Done.

[lisandrop, 2015-02-10 21:40:53]

New patchsets have been uploaded after l-g-t-m from cjhopman@chromium.org

[Dirk Pranke, 2015-02-10 22:44:45]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-02-10 22:44:46]

I'm not sure I understand this change. Does a user not have to now run both
scripts in order to be able to build?

[lisandrop, 2015-02-10 22:59:19]

On 2015/02/10 22:44:46, Dirk Pranke wrote:
> I'm not sure I understand this change. Does a user not have to now run both
> scripts in order to be able to build?

No, you can still install everything using build/install-build-deps-android.sh.
What this allows is to install user-dependencies (SDK) via
build/install-android-sdks.sh instead of being forced to use the former, which
requires sudo permissions to work.

In our particular case this allow us to set up a continuous build where the SDK
install can be a part of the build process, as the SDK must be installed on the
working code checkout to work.

[Dirk Pranke, 2015-02-10 23:03:06]

Okay. I'm not sure I see a big improvement here, but as long as the user only
has to run one command to get everything, I'm fine with splitting part of it
out.