Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 916433002: Fix analyze step on ios_rel_device bots. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix analyze step on ios_rel_device bots. BUG=454416 Committed: https://crrev.com/82dd46ca8cdeacf7f0ba4759062901072f2b0429 Cr-Commit-Position: refs/heads/master@{#315600}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/all.gyp View 1 2 3 1 chunk +0 lines, -1 line 2 comments Download
M testing/iossim/iossim.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/protobuf/protobuf.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jam
https://codereview.chromium.org/916433002/diff/60001/build/all.gyp File build/all.gyp (left): https://codereview.chromium.org/916433002/diff/60001/build/all.gyp#oldcode62 build/all.gyp:62: '../third_party/mojo/mojo_edk_tests.gyp:mojo_public_system_perftests', I don't know why this is needed, see ...
5 years, 10 months ago (2015-02-10 17:47:08 UTC) #2
jam
https://codereview.chromium.org/916433002/diff/60001/build/all.gyp File build/all.gyp (left): https://codereview.chromium.org/916433002/diff/60001/build/all.gyp#oldcode62 build/all.gyp:62: '../third_party/mojo/mojo_edk_tests.gyp:mojo_public_system_perftests', On 2015/02/10 17:47:08, jam wrote: > I don't ...
5 years, 10 months ago (2015-02-10 17:47:42 UTC) #3
sky
LGTM
5 years, 10 months ago (2015-02-10 18:31:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916433002/60001
5 years, 10 months ago (2015-02-10 18:46:12 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-10 18:50:06 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 18:50:40 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/82dd46ca8cdeacf7f0ba4759062901072f2b0429
Cr-Commit-Position: refs/heads/master@{#315600}

Powered by Google App Engine
This is Rietveld 408576698