Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 916423002: Tooltip Cleanup (Closed)

Created:
5 years, 10 months ago by oshima
Modified:
5 years, 10 months ago
Reviewers:
Jun Mukai, sky
CC:
chromium-reviews, kalyank, noyau+watch_chromium.org, tdanderson+views_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tooltip Cleanup This is prep for tooltip improvement: https://codereview.chromium.org/924433002/ (WIP) * Consolidated GetMaxWidth * Eliminate screen type argument. This can be obtained from tooltip window. * Move tooltip truncate code from TooltipManager to TooltipController BUG=None TEST=no functional change. all test should pass. Committed: https://crrev.com/ebbe63774233a330d0ccabb2fd129bdf41b036ac Cr-Commit-Position: refs/heads/master@{#317081}

Patch Set 1 : #

Patch Set 2 : win build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -79 lines) Patch
M ash/shell.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ui/views/corewm/tooltip.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/corewm/tooltip_aura.h View 4 chunks +3 lines, -6 lines 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 4 chunks +12 lines, -14 lines 0 comments Download
M ui/views/corewm/tooltip_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/corewm/tooltip_controller.cc View 4 chunks +9 lines, -2 lines 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/corewm/tooltip_win.h View 2 chunks +9 lines, -7 lines 0 comments Download
M ui/views/corewm/tooltip_win.cc View 1 2 chunks +11 lines, -6 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/tooltip_manager.h View 2 chunks +4 lines, -9 lines 0 comments Download
M ui/views/widget/tooltip_manager.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M ui/views/widget/tooltip_manager_aura.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/tooltip_manager_aura.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/wm/public/tooltip_client.h View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
oshima
5 years, 10 months ago (2015-02-12 16:32:25 UTC) #4
oshima
sadrul, sky@ is OOO. Can you review this?
5 years, 10 months ago (2015-02-13 21:29:30 UTC) #8
oshima
Scott, can you review this?
5 years, 10 months ago (2015-02-19 05:34:09 UTC) #11
sky
LGTM
5 years, 10 months ago (2015-02-19 17:03:51 UTC) #12
sadrul
On 2015/02/13 21:29:30, oshima (OOO Fab 17 - Feb 20) wrote: > sadrul, sky@ is ...
5 years, 10 months ago (2015-02-19 17:40:25 UTC) #13
Jun Mukai
On 2015/02/19 17:40:25, sadrul wrote: > On 2015/02/13 21:29:30, oshima (OOO Fab 17 - Feb ...
5 years, 10 months ago (2015-02-19 17:44:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916423002/60001
5 years, 10 months ago (2015-02-19 17:45:41 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 10 months ago (2015-02-19 18:41:55 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 18:42:50 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ebbe63774233a330d0ccabb2fd129bdf41b036ac
Cr-Commit-Position: refs/heads/master@{#317081}

Powered by Google App Engine
This is Rietveld 408576698