Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 916403003: Make dispatchIfAlive ensure the life of its queue. (Closed)

Created:
5 years, 10 months ago by dominicc (has gone to gerrit)
Modified:
5 years, 10 months ago
Reviewers:
Hajime Morrita
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org, kochi
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make dispatchIfAlive ensure the life of its queue. This is a speculative attempt to fix Issue 456636. CustomElementSyncMicrotaskRunQueue::dispatchIfAlive checks that the object is alive when it starts running callbacks, but doesn't ensure the object lives for the duration of the callbacks. Since the callbacks can run author JavaScript, the assumption that whatever kept the object alive will continue to do so might be too optimistic. Additionally, strengthen the assertion that queue processing is non-reentrant. BUG=456636 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/core/dom/custom/CustomElementMicrotaskQueueBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskRunQueue.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dominicc (has gone to gerrit)
PTAL, morrita, you're probably the best (only?) person to review this. Ideas welcome--I'll CC you ...
5 years, 10 months ago (2015-02-17 03:41:02 UTC) #2
Hajime Morrita
LGTM. I think kochi-san is looking into similar bug but not sure if it is ...
5 years, 10 months ago (2015-02-23 20:42:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916403003/1
5 years, 10 months ago (2015-02-24 07:20:24 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 07:23:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190720

Powered by Google App Engine
This is Rietveld 408576698