Issue 916373002: Oilpan: allow StoppingOtherThreads GC state transition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 916373002: Oilpan: allow StoppingOtherThreads GC state transition. (Closed)

Created:
5 years, 10 months ago by sof

Modified:
5 years, 10 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: allow StoppingOtherThreads GC state transition. If collectGarbage() fails to park all threads, the GCState is reset from StoppingOtherThreads back to its previous state. If collectAllGarbage() is what brings about that GC, then collectGarbage()'s incoming GCState will either be GCScheduledForTesting or NoGCScheduled. setGCState()'s asserts lacked permission for a StoppingOtherThreads => NoGCScheduled transition. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190033

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/platform/heap/ThreadState.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

Please take a look. Assert encountered on https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win_Oilpan__dbg_/5172/layout-test-results/loader/iframe-src-change-onload-crash-crash-log.txt

5 years, 10 months ago (2015-02-12 08:12:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916373002/1

5 years, 10 months ago (2015-02-12 08:38:59 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-12 09:31:19 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190033

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages