Enable pinch-zoom on the new login page.

Enable pinch-zoom on the new login page.

This CL enables webview tags with allowsscaling="on" to respond to
pinch touch gestures.

BUG=453785
Committed: https://crrev.com/6dbeccbba83efe41a2f9e65f40cd3c69d8c211e3
Cr-Commit-Position: refs/heads/master@{#316307}

[wjmaclean, 2015-02-12 21:16:20]

wjmaclean@chromium.org changed reviewers:
+ fsamuel@chromium.org, xiyuan@chromium.org

[wjmaclean, 2015-02-12 21:16:20]

This is a first draft; please let me know if the approach seems reasonable.

xiyuan@chromium.org: Please review changes in chrome/browser/resources

fsamuel@chromium.org: Please review changes in 
extensions/

[Fady Samuel, 2015-02-12 21:27:09]

This looks like it's generally good to me after comments are addressed.

https://codereview.chromium.org/916363003/diff/1/chrome/browser/resources/inl...
File chrome/browser/resources/inline_login/new_inline_login.html (right):

https://codereview.chromium.org/916363003/diff/1/chrome/browser/resources/inl...
chrome/browser/resources/inline_login/new_inline_login.html:18: <webview
id="signin-frame" name="signin-frame" allowscaling="on"></webview>
allowscaling should be sufficient: no need for ="on".

Boolean Attributes only check for existence of the attribute, not the value

https://codereview.chromium.org/916363003/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/web_view/web_view_guest.cc (right):

https://codereview.chromium.org/916363003/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/web_view/web_view_guest.cc:448: return
allow_scaling_ ? false
return !allow_scaling_ && GuestViewBase::PreHandleGestureEvent(source, event);

https://codereview.chromium.org/916363003/diff/1/extensions/renderer/resource...
File extensions/renderer/resources/guest_view/web_view_attributes.js (right):

https://codereview.chromium.org/916363003/diff/1/extensions/renderer/resource...
extensions/renderer/resources/guest_view/web_view_attributes.js:104: newValue) {
nit: alignment.

[wjmaclean, 2015-02-12 21:40:36]

wjmaclean@chromium.org changed reviewers:
+ mpearson@chromium.org

[wjmaclean, 2015-02-12 21:41:25]

Comments addressed, PTAL?

mpearson@ - can you please look at extension_function_histogram_value.h ? Thanks
...

https://codereview.chromium.org/916363003/diff/1/chrome/browser/resources/inl...
File chrome/browser/resources/inline_login/new_inline_login.html (right):

https://codereview.chromium.org/916363003/diff/1/chrome/browser/resources/inl...
chrome/browser/resources/inline_login/new_inline_login.html:18: <webview
id="signin-frame" name="signin-frame" allowscaling="on"></webview>
On 2015/02/12 21:27:09, Fady Samuel wrote:
> allowscaling should be sufficient: no need for ="on".
> 
> Boolean Attributes only check for existence of the attribute, not the value

Done.

I was following the documentation at
https://developer.chrome.com/apps/tags/webview for "allowtransparency", perhaps
that should be updated?

https://codereview.chromium.org/916363003/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/web_view/web_view_guest.cc (right):

https://codereview.chromium.org/916363003/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/web_view/web_view_guest.cc:448: return
allow_scaling_ ? false
On 2015/02/12 21:27:09, Fady Samuel wrote:
> return !allow_scaling_ && GuestViewBase::PreHandleGestureEvent(source, event);

Done.

https://codereview.chromium.org/916363003/diff/1/extensions/renderer/resource...
File extensions/renderer/resources/guest_view/web_view_attributes.js (right):

https://codereview.chromium.org/916363003/diff/1/extensions/renderer/resource...
extensions/renderer/resources/guest_view/web_view_attributes.js:104: newValue) {
On 2015/02/12 21:27:09, Fady Samuel wrote:
> nit: alignment.

Done.

[Fady Samuel, 2015-02-12 21:43:15]

lgtm

[Mark P, 2015-02-12 22:14:03]

On 2015/02/12 21:41:25, wjmaclean wrote:
> Comments addressed, PTAL?
> 
> mpearson@ - can you please look at extension_function_histogram_value.h ?
Thanks

Please follow the instructions in the comment immediately next to the line you
modified and make the corresponding change in histograms.xml.

--mark

[wjmaclean, 2015-02-13 15:29:13]

New patchsets have been uploaded after l-g-t-m from fsamuel@chromium.org

[wjmaclean, 2015-02-13 15:30:14]

mpearson@ - PTAL

[Mark P, 2015-02-13 16:34:59]

histograms lgtm

[xiyuan, 2015-02-13 17:14:34]

chrome/browser/resources LGTM

[wjmaclean, 2015-02-13 17:24:05]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2015-02-13 17:24:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/916363003/40001

[commit-bot: I haz the power, 2015-02-13 17:28:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-13 17:28:07]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[wjmaclean, 2015-02-13 20:05:21]

New patchsets have been uploaded after l-g-t-m from
mpearson@chromium.org,xiyuan@chromium.org

[wjmaclean, 2015-02-13 20:05:57]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2015-02-13 20:07:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/916363003/60001

[commit-bot: I haz the power, 2015-02-13 21:10:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-13 21:10:18]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wjmaclean, 2015-02-13 21:11:46]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2015-02-13 21:12:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/916363003/60001

[commit-bot: I haz the power, 2015-02-13 22:17:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-13 22:17:35]

Patchset 4 (id:??) landed as
https://crrev.com/6dbeccbba83efe41a2f9e65f40cd3c69d8c211e3
Cr-Commit-Position: refs/heads/master@{#316307}