Issue 916313004: Fix subzero translator to use new API for reporting errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 916313004: Fix subzero translator to use new API for reporting errors. (Closed)

Created:
5 years, 10 months ago by Karl

Modified:
5 years, 9 months ago

Reviewers:
jvoung (off chromium), Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix subzero translator to use new API for reporting errors. The error handling in LLVM for errors has been updated so that errors in the bitcode stream no longer cause (assertion crashes). This CL applies the appropriate changes to subzero. See CL https://codereview.chromium.org/932953002 for changes to error handling for LLVM. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4002 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=22ed4eb40f1b4e0b92d5ac0db91a8a31824aa49d

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -220 lines)			Patch
M	src/PNaClTranslator.cpp	View	1 2 3 4	13 chunks	+24 lines, -32 lines	0 comments	Download
M	tests_lit/parse_errs/insertextract-err.ll	View	1 2 3 4	1 chunk	+84 lines, -84 lines	0 comments	Download
M	tests_lit/parse_errs/nacl-fake-intrinsic.ll	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	unittest/IceParseInstsTest.cpp	View	1 2 3	17 chunks	+34 lines, -102 lines	0 comments	Download

Total messages: 4 (1 generated)

Karl

5 years, 9 months ago (2015-03-04 20:17:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as
22ed4eb40f1b4e0b92d5ac0db91a8a31824aa49d (presubmit successful).