Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 916293004: Fix location of super syntax errors (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix location of super syntax errors BUG=v8:3885 LOG=N R=adamk@chromium.org, dslomov@chromium.org Committed: https://crrev.com/fd5a0de2af9d33be2d8871b3c40f484c8b15956a Cr-Commit-Position: refs/heads/master@{#26632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M src/preparser.h View 2 chunks +1 line, -2 lines 0 comments Download
A + test/message/super-in-function.js View 1 chunk +4 lines, -6 lines 0 comments Download
A + test/message/super-in-function.out View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
arv (Not doing code reviews)
PTAL
5 years, 10 months ago (2015-02-12 20:21:58 UTC) #2
adamk
lgtm
5 years, 10 months ago (2015-02-12 20:27:07 UTC) #3
Dmitry Lomov (no reviews)
lgtm
5 years, 10 months ago (2015-02-12 20:31:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916293004/1
5 years, 10 months ago (2015-02-12 20:36:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2960)
5 years, 10 months ago (2015-02-12 20:45:24 UTC) #8
arv (Not doing code reviews)
Committed patchset #1 (id:1) manually as fd5a0de2af9d33be2d8871b3c40f484c8b15956a (presubmit successful).
5 years, 10 months ago (2015-02-12 20:53:24 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 20:53:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd5a0de2af9d33be2d8871b3c40f484c8b15956a
Cr-Commit-Position: refs/heads/master@{#26632}

Powered by Google App Engine
This is Rietveld 408576698