Remove ash default frame highlighting for custom colored frames.

Remove ash default frame highlighting for custom colored frames.

The default highlighting color only works with the default frame color,
so it shouldn't be shown in other cases.

BUG=453783
Committed: https://crrev.com/4745d29938934bf1a75e67772a3be85361f0f238
Cr-Commit-Position: refs/heads/master@{#316119}

[benwells, 2015-02-12 01:37:08]

benwells@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[pkotwicz, 2015-02-12 02:04:52]

https://codereview.chromium.org/916293002/diff/1/ash/frame/default_header_pai...
File ash/frame/default_header_painter.cc (right):

https://codereview.chromium.org/916293002/diff/1/ash/frame/default_header_pai...
ash/frame/default_header_painter.cc:245: if (HasCustomFrameColors())
I think it would make more sense to add this logic to the caller. There are
already a bunch of conditions which control whether this method gets called.
Yes, this function name will no longer be accurate but I think that's ok

https://codereview.chromium.org/916293002/diff/1/ash/frame/default_header_pai...
File ash/frame/default_header_painter.h (right):

https://codereview.chromium.org/916293002/diff/1/ash/frame/default_header_pai...
ash/frame/default_header_painter.h:88: // Returns whether the frame has any
custom frame coloring.
Nit: I think that UsesCustomFrameColors() is a slightly more descriptive
function name

[benwells, 2015-02-12 02:36:10]

https://codereview.chromium.org/916293002/diff/1/ash/frame/default_header_pai...
File ash/frame/default_header_painter.cc (right):

https://codereview.chromium.org/916293002/diff/1/ash/frame/default_header_pai...
ash/frame/default_header_painter.cc:245: if (HasCustomFrameColors())
On 2015/02/12 02:04:52, pkotwicz wrote:
> I think it would make more sense to add this logic to the caller. There are
> already a bunch of conditions which control whether this method gets called.
> Yes, this function name will no longer be accurate but I think that's ok

Done.

https://codereview.chromium.org/916293002/diff/1/ash/frame/default_header_pai...
File ash/frame/default_header_painter.h (right):

https://codereview.chromium.org/916293002/diff/1/ash/frame/default_header_pai...
ash/frame/default_header_painter.h:88: // Returns whether the frame has any
custom frame coloring.
On 2015/02/12 02:04:52, pkotwicz wrote:
> Nit: I think that UsesCustomFrameColors() is a slightly more descriptive
> function name

Done.

[pkotwicz, 2015-02-12 18:43:06]

lgtm

https://codereview.chromium.org/916293002/diff/20001/ash/frame/default_header...
File ash/frame/default_header_painter.h (right):

https://codereview.chromium.org/916293002/diff/20001/ash/frame/default_header...
ash/frame/default_header_painter.h:88: // Returns whether the frame has any
custom frame coloring.
Nit: "has any custom" -> "uses custom"

[benwells, 2015-02-12 22:54:31]

New patchsets have been uploaded after l-g-t-m from pkotwicz@chromium.org

[benwells, 2015-02-12 22:56:28]

Patchset #3 (id:40001) has been deleted

[benwells, 2015-02-12 22:56:55]

https://codereview.chromium.org/916293002/diff/20001/ash/frame/default_header...
File ash/frame/default_header_painter.h (right):

https://codereview.chromium.org/916293002/diff/20001/ash/frame/default_header...
ash/frame/default_header_painter.h:88: // Returns whether the frame has any
custom frame coloring.
On 2015/02/12 18:43:05, pkotwicz wrote:
> Nit: "has any custom" -> "uses custom"

Done.

https://codereview.chromium.org/916293002/diff/20001/ash/frame/default_header...
ash/frame/default_header_painter.h:88: // Returns whether the frame has any
custom frame coloring.
On 2015/02/12 18:43:05, pkotwicz wrote:
> Nit: "has any custom" -> "uses custom"

Done.

[benwells, 2015-02-12 22:56:59]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2015-02-12 22:57:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/916293002/60001

[commit-bot: I haz the power, 2015-02-13 01:21:09]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-02-13 01:21:34]

Patchset 3 (id:??) landed as
https://crrev.com/4745d29938934bf1a75e67772a3be85361f0f238
Cr-Commit-Position: refs/heads/master@{#316119}