Source/core/loader/DocumentLoader.h - Issue 916273002: Make DocumentLoader::timing return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/DocumentLoader.h

Issue 916273002: Make DocumentLoader::timing return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/DocumentLoader.h

diff --git a/Source/core/loader/DocumentLoader.h b/Source/core/loader/DocumentLoader.h

index e0220b6f489fa9decc703bedec5478939056f439..284a8d2ee67b879b520c3b55469c60e79ed9a658 100644

--- a/Source/core/loader/DocumentLoader.h

+++ b/Source/core/loader/DocumentLoader.h

@@ -116,7 +116,8 @@ namespace blink {

void attachThreadedDataReceiver(PassRefPtrWillBeRawPtr<ThreadedDataReceiver>);

void acceptDataFromThreadedReceiver(const char* data, int dataLength, int encodedDataLength);

- DocumentLoadTiming* timing() { return &m_documentLoadTiming; }

+ DocumentLoadTiming& timing() { return m_documentLoadTiming; }

+ const DocumentLoadTiming& timing() const { return m_documentLoadTiming; }

Nate Chapin 2015/02/12 18:14:31 It also makes me sad to need separate const and no

ApplicationCacheHost* applicationCacheHost() const { return m_applicationCacheHost.get(); }