Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 916273002: Make DocumentLoader::timing return a reference (Closed)

Created:
5 years, 10 months ago by rwlbuis
Modified:
5 years, 10 months ago
Reviewers:
Nate Chapin, Mike West
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dstockwell, eae+blinkwatch, Eric Willigers, eustas+blink_chromium.org, falken, gavinp+loader_chromium.org, horo+watch_chromium.org, kinuko+worker_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, Mike Lawther (Google), pfeldman+blink_chromium.org, rjwright, sergeyv+blink_chromium.org, shans, sof, Steve Block, Timothy Loh, tyoshino+watch_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make DocumentLoader::timing return a reference To make it more clear the DocumentLoadTiming object can't be null make it a reference. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190154

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase against ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -34 lines) Patch
M Source/core/animation/AnimationTimeline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/ScriptedAnimationController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/DocumentLoader.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/Performance.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/PerformanceNavigation.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/timing/PerformanceResourceTiming.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/PerformanceTiming.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/performance/SharedWorkerPerformance.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIAccess.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebDataSourceImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (12 generated)
rwlbuis
PTAL
5 years, 10 months ago (2015-02-12 00:42:29 UTC) #2
Nate Chapin
LGTM https://codereview.chromium.org/916273002/diff/1/Source/core/loader/DocumentLoader.h File Source/core/loader/DocumentLoader.h (right): https://codereview.chromium.org/916273002/diff/1/Source/core/loader/DocumentLoader.h#newcode120 Source/core/loader/DocumentLoader.h:120: const DocumentLoadTiming& timing() const { return m_documentLoadTiming; } ...
5 years, 10 months ago (2015-02-12 18:14:31 UTC) #3
rwlbuis
On 2015/02/12 18:14:31, Nate Chapin wrote: > LGTM > > https://codereview.chromium.org/916273002/diff/1/Source/core/loader/DocumentLoader.h > File Source/core/loader/DocumentLoader.h (right): ...
5 years, 10 months ago (2015-02-12 18:32:47 UTC) #4
Nate Chapin
On 2015/02/12 18:32:47, rwlbuis wrote: > On 2015/02/12 18:14:31, Nate Chapin wrote: > > LGTM ...
5 years, 10 months ago (2015-02-12 18:42:05 UTC) #5
rwlbuis
On 2015/02/12 18:42:05, Nate Chapin wrote: > On 2015/02/12 18:32:47, rwlbuis wrote: > > On ...
5 years, 10 months ago (2015-02-12 18:44:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916273002/1
5 years, 10 months ago (2015-02-12 18:45:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/26467)
5 years, 10 months ago (2015-02-12 18:59:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916273002/1
5 years, 10 months ago (2015-02-12 20:08:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/26477)
5 years, 10 months ago (2015-02-12 20:15:38 UTC) #14
rwlbuis
@mkwst I need you for the modules changes :)
5 years, 10 months ago (2015-02-12 20:21:43 UTC) #16
Mike West
modules/ LGTM.
5 years, 10 months ago (2015-02-13 04:56:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916273002/1
5 years, 10 months ago (2015-02-13 11:51:06 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/26552)
5 years, 10 months ago (2015-02-13 11:55:41 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916273002/1
5 years, 10 months ago (2015-02-13 12:50:51 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/26560)
5 years, 10 months ago (2015-02-13 12:58:13 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916273002/20001
5 years, 10 months ago (2015-02-13 16:07:28 UTC) #28
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 17:48:24 UTC) #29
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190154

Powered by Google App Engine
This is Rietveld 408576698