Enable keyboard shortcuts for chrome://extensions

chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extension_settings_browsertest.h"
 
 #include "base/files/file_path.h"
 #include "base/path_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 44 matching lines @@
 void ExtensionSettingsUIBrowserTest::InstallGoodExtension() {
   base::FilePath test_data_dir;
   if (!PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir)) {
     ADD_FAILURE();
     return;
   }
   base::FilePath extensions_data_dir = test_data_dir.AppendASCII("extensions");
   InstallExtension(extensions_data_dir.AppendASCII("good.crx"));
 }
 
+void ExtensionSettingsUIBrowserTest::InstallErrorsExtension() {
+  base::FilePath test_data_dir;
+  if (!PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir)) {
+    ADD_FAILURE();
+    return;
+  }
+  base::FilePath extensions_data_dir = test_data_dir.AppendASCII("extensions");
+  extensions_data_dir = extensions_data_dir.AppendASCII("error_console");
+  InstallUnpackedExtension(
+      extensions_data_dir.AppendASCII("runtime_and_manifest_errors"));
+}
+
 void ExtensionSettingsUIBrowserTest::AddManagedPolicyProvider() {
   auto* extension_service = extensions::ExtensionSystem::Get(GetProfile());
   extension_service->management_policy()->RegisterProvider(&policy_provider_);
 }
 
 class MockAutoConfirmExtensionInstallPrompt : public ExtensionInstallPrompt {
  public:
   explicit MockAutoConfirmExtensionInstallPrompt(
       content::WebContents* web_contents)
     : ExtensionInstallPrompt(web_contents) {}
 
   // Proceed without confirmation prompt.
   void ConfirmInstall(Delegate* delegate,
                       const Extension* extension,
                       const ShowDialogCallback& show_dialog_callback) override {
     delegate->InstallUIProceed();
   }
 };
 
+void ExtensionSettingsUIBrowserTest::InstallUnpackedExtension(
+    const base::FilePath& path) {
+  ExtensionService* service =
+      extensions::ExtensionSystem::Get(this->GetProfile())->extension_service();

[Dan Beam, 2015/02/21 00:26:10]

this->GetProfile() should be just GetProfile()

[hcarmona, 2015/02/23 22:25:08]

Done. Too used to JS

+  extensions::UnpackedInstaller::Create(service)->Load(path);
+}
+
 const Extension* ExtensionSettingsUIBrowserTest::InstallExtension(
     const base::FilePath& path) {
   Profile* profile = this->GetProfile();
   ExtensionService* service =
       extensions::ExtensionSystem::Get(profile)->extension_service();
   extensions::ExtensionRegistry* registry =
       extensions::ExtensionRegistry::Get(profile);
   service->set_show_extensions_prompts(false);
   size_t num_before = registry->enabled_extensions().size();
   {
@@ skipping 41 matching lines @@
          iter != errors->end(); ++iter)
       VLOG(1) << *iter;
 
     return NULL;
   }
 
   if (!observer_->WaitForExtensionViewsToLoad())
     return NULL;
   return service->GetExtensionById(last_loaded_extension_id(), false);
 }