Enable keyboard shortcuts for chrome://extensions

chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(dbeam): test for loading upacked extensions?
 
 GEN('#include "chrome/browser/ui/webui/extensions/' +
     'extension_settings_browsertest.h"');
 
 // chrome/test/data/extensions/good.crx's extension ID. good.crx is loaded by
@@ skipping 45 matching lines @@
   assertTrue($('pack-extension-overlay').classList.contains('showing'));
 });
 
 function AsyncExtensionSettingsWebUITest() {}
 
 AsyncExtensionSettingsWebUITest.prototype = {
   __proto__: ExtensionSettingsWebUITest.prototype,
 
   /** @override */
   isAsync: true,
+
+  /** @override */
+  testGenPreamble: function() {
+    GEN('  InstallGoodExtension();');
+    GEN('  InstallErrorsExtension();');

[Dan Beam, 2015/02/20 23:36:43]

doesn't care about the return value

[hcarmona, 2015/02/21 00:16:01]

Acknowledged.

+  },
+
+  enableDeveloperMode: function(callback) {
+    var devControls = $('dev-controls');
+
+    // Make sure developer controls are hidden before checkbox is clicked.
+    assertEquals(0, devControls.offsetHeight);
+    $('toggle-dev-on').click();
+
+    document.addEventListener('webkitTransitionEnd', function f(e) {
+      if (e.target == devControls) {
+        // Make sure developer controls are not hidden after checkbox is
+        // clicked.
+        assertGT(devControls.offsetHeight, 0);
+
+        document.removeEventListener(f, 'webkitTransitionEnd');
+        callback();
+      }
+    });
+    ensureTransitionEndEvent(devControls, 4000);
+  },
 };
 
 TEST_F('AsyncExtensionSettingsWebUITest', 'testDeveloperModeA11y', function() {
-  var devControls = $('dev-controls');
+  this.enableDeveloperMode(testDone);
+});
 
-  // Make sure developer controls are hidden before checkbox is clicked.
-  assertEquals(0, devControls.offsetHeight);
-  $('toggle-dev-on').click();
+TEST_F('AsyncExtensionSettingsWebUITest', 'testErrorListButtonVisibility',
+    function() {
+  this.enableDeveloperMode(function() {
+    // 2 extensions are loaded:
+    //   The 'good' extension will have 0 errors wich means no error list
+    //     buttons.
+    //   The 'bad' extension will have >3 manifest errors and <3 runtime errors.
+    //     This means 2 buttons: 1 visible and 1 hidden.
 

[Dan Beam, 2015/02/20 23:36:43]

nit: remove \n

[hcarmona, 2015/02/21 00:16:01]

Done.

-  document.addEventListener('webkitTransitionEnd', function f(e) {
-    if (e.target == devControls) {
-      // Make sure developer controls are not hidden after checkbox is clicked.
-      assertGT(devControls.offsetHeight, 0);
+    var visibleButtons = document.querySelectorAll(
+        '.extension-error-list-show-more > a:not([hidden])');
+    assertEquals(1, visibleButtons.length);
+    // Visible buttons must be part of the focusRow.
+    assertTrue(visibleButtons[0].hasAttribute('column-type'));
 
-      document.removeEventListener(f, 'webkitTransitionEnd');
-      testDone();
-    }
+    var hiddenButtons = document.querySelectorAll(
+        '.extension-error-list-show-more > a[hidden]');
+    assertEquals(1, hiddenButtons.length);
+    // Hidden buttons must NOT be part of the focusRow.
+    assertFalse(hiddenButtons[0].hasAttribute('column-type'));
+
+    testDone();
   });
-  ensureTransitionEndEvent(devControls, 4000);
 });
 
 /**
  * TestFixture for extension settings WebUI testing (commands config edition).
  * @extends {testing.Test}
  * @constructor
  */
 function ExtensionSettingsCommandsConfigWebUITest() {}
 
 ExtensionSettingsCommandsConfigWebUITest.prototype = {
@@ skipping 94 matching lines @@
 
 ExtensionOptionsDialogWebUITest.prototype = {
   __proto__: InstalledExtensionSettingsWebUITest.prototype,
 
   /** @override */
   browsePreload: ExtensionSettingsWebUITest.prototype.browsePreload +
       '?options=' + GOOD_CRX_ID,
 };
 
 TEST_F('ExtensionOptionsDialogWebUITest', 'testAccessibility', runAudit);