Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 91623004: Add media perf benchamrk under network simulations. (Closed)

Created:
7 years ago by shadi
Modified:
7 years ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add media perf benchamrk under network simulations. The tests uses media served by cns.chrome:9000/ server under cable and wifi network conditions. BUG=311713 TEST=run_benchmark media.media_cns_cases NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238419

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -35 lines) Patch
M tools/perf/benchmarks/media.py View 1 chunk +5 lines, -0 lines 0 comments Download
A tools/perf/page_sets/media_cns_cases.json View 1 chunk +76 lines, -0 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases.json View 3 chunks +14 lines, -9 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/video.html View 1 chunk +45 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
shadi
Can you PTAL? https://codereview.chromium.org/91623004/diff/1/tools/perf/metrics/media.py File tools/perf/metrics/media.py (right): https://codereview.chromium.org/91623004/diff/1/tools/perf/metrics/media.py#newcode61 tools/perf/metrics/media.py:61: results.Add(trace + special_label, unit, float(metrics[m]), Not ...
7 years ago (2013-11-27 19:58:11 UTC) #1
dtu
lgtm
7 years ago (2013-12-02 19:39:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/91623004/20001
7 years ago (2013-12-03 00:06:33 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195712
7 years ago (2013-12-03 02:51:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/91623004/20001
7 years ago (2013-12-03 17:09:18 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-03 17:17:57 UTC) #6
Message was sent while issue was closed.
Change committed as 238419

Powered by Google App Engine
This is Rietveld 408576698