Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 916213003: Always send TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED. (Closed)

Created:
5 years, 10 months ago by dmazzoni
Modified:
5 years, 10 months ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, caseyburkhardt_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@editable_text_events_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always send TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED. This logic was borrowed from ExploreByTouchHelper, but apparently it's wrong, because TalkBack sends ACTION_ACCESSIBILITY_FOCUS on a new view id and then ACTION_CLEAR_ACCESSIBILITY_FOCUS on the old view id, and since we didn't think the old view had accessibility focus, we never responded with a TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED event, so the framework would sometimes not update its cache, and TalkBack could think the old view still had accessibility focus. BUG=458343 Committed: https://crrev.com/ba0498563648b585274589f947bb57cffcdc0278 Cr-Commit-Position: refs/heads/master@{#316238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
5 years, 10 months ago (2015-02-12 23:37:58 UTC) #2
Peter Lundblad
lgtm
5 years, 10 months ago (2015-02-13 17:04:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916213003/1
5 years, 10 months ago (2015-02-13 17:06:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 17:51:58 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 17:52:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba0498563648b585274589f947bb57cffcdc0278
Cr-Commit-Position: refs/heads/master@{#316238}

Powered by Google App Engine
This is Rietveld 408576698