ui/gfx/canvas_skia.cc - Issue 916203002: Reduce the number of text reshaping in RenderText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/canvas_skia.cc

Issue 916203002: Reduce the number of text reshaping in RenderText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/canvas_skia.cc

diff --git a/ui/gfx/canvas_skia.cc b/ui/gfx/canvas_skia.cc

index 5bb21c4b486dfa31b01816f5ada18c9bde7ba92b..73f5992406cbed173b8676ea7863fbd7c616a1d6 100644

--- a/ui/gfx/canvas_skia.cc

+++ b/ui/gfx/canvas_skia.cc

@@ -292,7 +292,7 @@ void Canvas::DrawStringRectWithShadows(const base::string16& text,

// for LTR text. RTL text is still elided (on the left) with "...".

if (elide_text) {

render_text->SetText(adjusted_text);

- if (render_text->GetTextDirection() == base::i18n::LEFT_TO_RIGHT) {

+ if (render_text->GetDisplayTextDirection() == base::i18n::LEFT_TO_RIGHT) {

render_text->SetElideBehavior(FADE_TAIL);

elide_text = false;

}

« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_result_view.cc ('k') | ui/gfx/render_text.h » ('j') | no next file with comments »