chrome/browser/metrics/chrome_metrics_service_accessor_unittest.cc - Issue 916133003: Fix ChromeMetricsServiceAccessor::IsMetricsReportingEnabled on CrOs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_accessor_unittest.cc

Issue 916133003: Fix ChromeMetricsServiceAccessor::IsMetricsReportingEnabled on CrOs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase before submit Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_accessor.cc ('k') | chrome/browser/metrics/metrics_services_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_service_accessor_unittest.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_accessor_unittest.cc b/chrome/browser/metrics/chrome_metrics_service_accessor_unittest.cc

index dc0271bd52afb771a1619ca4c50da953281e2f5d..7c93160aacfdc0df437ed600b953593dd0d48c2f 100644

--- a/chrome/browser/metrics/chrome_metrics_service_accessor_unittest.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_accessor_unittest.cc

@@ -26,6 +26,7 @@ class ChromeMetricsServiceAccessorTest : public testing::Test {

};

TEST_F(ChromeMetricsServiceAccessorTest, MetricsReportingEnabled) {

+#if defined(GOOGLE_CHROME_BUILD)

#if !defined(OS_CHROMEOS)

GetLocalState()->SetBoolean(prefs::kMetricsReportingEnabled, false);

EXPECT_FALSE(ChromeMetricsServiceAccessor::IsMetricsReportingEnabled());

@@ -38,6 +39,10 @@ TEST_F(ChromeMetricsServiceAccessorTest, MetricsReportingEnabled) {

// device settings for metrics reporting.

EXPECT_FALSE(ChromeMetricsServiceAccessor::IsMetricsReportingEnabled());

#endif

+#else

+ // Metrics Reporting is never enabled when GOOGLE_CHROME_BUILD is undefined.

+ EXPECT_FALSE(ChromeMetricsServiceAccessor::IsMetricsReportingEnabled());

+#endif

}

TEST_F(ChromeMetricsServiceAccessorTest, CrashReportingEnabled) {

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_accessor.cc ('k') | chrome/browser/metrics/metrics_services_manager.h » ('j') | no next file with comments »