chrome/browser/metrics/metrics_services_manager.h - Issue 916133003: Fix ChromeMetricsServiceAccessor::IsMetricsReportingEnabled on CrOs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_services_manager.h

Issue 916133003: Fix ChromeMetricsServiceAccessor::IsMetricsReportingEnabled on CrOs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make MetricsServicesManager::IsMetricsReportingEnabled private Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/chrome_metrics_service_accessor.cc ('K') | « chrome/browser/metrics/chrome_metrics_service_accessor_unittest.cc ('k') | chrome/browser/metrics/metrics_services_manager.cc » ('j') | chrome/browser/metrics/metrics_services_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_services_manager.h

diff --git a/chrome/browser/metrics/metrics_services_manager.h b/chrome/browser/metrics/metrics_services_manager.h

index b0f2670bacc9ed9fb3002c2f99fb914b95b4dc17..92ca58fa6252a51634249c23032375aaf8bb24a9 100644

--- a/chrome/browser/metrics/metrics_services_manager.h

+++ b/chrome/browser/metrics/metrics_services_manager.h

@@ -55,10 +55,13 @@ class MetricsServicesManager {

// metrics change.

void UpdatePermissions(bool may_record, bool may_upload);

+ // Update the managed services when permissions for uploading metrics change.

+ void UpdateUploadPermissions(bool may_upload);

+ private:

// Returns true iff metrics reporting is enabled.

bool IsMetricsReportingEnabled() const;

- private:

// Returns the ChromeMetricsServiceClient, creating it if it hasn't been

// created yet (and additionally creating the MetricsService in that case).

ChromeMetricsServiceClient* GetChromeMetricsServiceClient();