chrome/browser/chrome_browser_main.cc - Issue 916133003: Fix ChromeMetricsServiceAccessor::IsMetricsReportingEnabled on CrOs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 916133003: Fix ChromeMetricsServiceAccessor::IsMetricsReportingEnabled on CrOs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make MetricsServicesManager::IsMetricsReportingEnabled private Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_browser_main.cc

diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc

index 75518a2f8d575ae0d583242e59e70fe639e4749f..86b46701602bdcc5d41bef20872b3123159fa9cd 100644

--- a/chrome/browser/chrome_browser_main.cc

+++ b/chrome/browser/chrome_browser_main.cc

@@ -671,11 +671,7 @@ void ChromeBrowserMainParts::StartMetricsRecording() {

g_browser_process->metrics_service()->CheckForClonedInstall(

BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));

- bool may_record = g_browser_process->GetMetricsServicesManager()->

- IsMetricsReportingEnabled();

- g_browser_process->GetMetricsServicesManager()->UpdatePermissions(

- may_record, true);

+ g_browser_process->GetMetricsServicesManager()->UpdateUploadPermissions(true);

}

void ChromeBrowserMainParts::RecordBrowserStartupTime() {

« no previous file with comments | « no previous file | chrome/browser/metrics/chrome_metrics_service_accessor.h » ('j') | chrome/browser/metrics/chrome_metrics_service_accessor.cc » ('J')