Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: gyp/common_variables.gypi

Issue 916113002: Don't use m32 cflag for x86_64. (Closed) Base URL: https://skia.googlesource.com/skia.git@baselijne
Patch Set: Make desktops distinguish between x86 and x86_64 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/common_conditions.gypi ('k') | gyp/opts.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_variables.gypi
diff --git a/gyp/common_variables.gypi b/gyp/common_variables.gypi
index f89c08b95e2f5a6879f43b4577c1fac67c4a5687..a20550b08d0d8feac5840ea86d6e99f55c42af7d 100644
--- a/gyp/common_variables.gypi
+++ b/gyp/common_variables.gypi
@@ -40,14 +40,23 @@
# Variables needed by conditions list within the level-2 variables dict.
'variables': { # level 3
- # We use 'skia_os' instead of 'OS' throughout our gyp files, to allow
- # for cross-compilation (e.g. building for either MacOS or iOS on Mac).
- # We set it automatically based on 'OS' (the host OS), but allow the
- # user to override it via GYP_DEFINES if they like.
- 'skia_os%': '<(OS)',
+ 'variables': { # level 4
+ # We use 'skia_os' instead of 'OS' throughout our gyp files, to allow
+ # for cross-compilation (e.g. building for either MacOS or iOS on Mac).
+ # We set it automatically based on 'OS' (the host OS), but allow the
+ # user to override it via GYP_DEFINES if they like.
+ 'skia_os%': '<(OS)',
+ },
+ 'skia_os%': '<(skia_os)',
'skia_android_framework%': 0,
- 'skia_arch_type%': 'x86',
+ 'conditions' : [
+ [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "mac"]', {
+ 'skia_arch_type%': 'x86_64',
+ }, {
+ 'skia_arch_type%': 'x86',
+ }],
+ ],
'arm_version%': 0,
'arm_neon%': 0,
'skia_egl%': 0,
@@ -82,7 +91,7 @@
}, {
'skia_poppler_enabled%': 0,
}],
- [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "mac"] or skia_arch_type == "arm64"', {
+ ['"64" in skia_arch_type', {
'skia_arch_width%': 64,
}, {
'skia_arch_width%': 32,
« no previous file with comments | « gyp/common_conditions.gypi ('k') | gyp/opts.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698