Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: gyp/common_variables.gypi

Issue 916113002: Don't use m32 cflag for x86_64. (Closed) Base URL: https://skia.googlesource.com/skia.git@baselijne
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gyp/common_variables.gypi
diff --git a/gyp/common_variables.gypi b/gyp/common_variables.gypi
index f89c08b95e2f5a6879f43b4577c1fac67c4a5687..5b5d2ebf013849484fb2a2b04eae014459014f52 100644
--- a/gyp/common_variables.gypi
+++ b/gyp/common_variables.gypi
@@ -82,7 +82,7 @@
}, {
'skia_poppler_enabled%': 0,
}],
- [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "mac"] or skia_arch_type == "arm64"', {
+ [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "mac"] or "64" in skia_arch_type', {
mtklein 2015/02/11 18:15:05 So are we going to get "x86" and "x86_64" as skia
scroggo 2015/02/11 20:12:10 I would like it to be the case for all builds (alt
scroggo 2015/02/11 20:15:26 And now of course I'm not sure of that. It appears
scroggo 2015/02/12 15:35:45 I made that change in https://codereview.chromium.
scroggo 2015/02/12 15:55:47 Pulled in that change here. PTAL.
'skia_arch_width%': 64,
}, {
'skia_arch_width%': 32,

Powered by Google App Engine
This is Rietveld 408576698