Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: gyp/common_conditions.gypi

Issue 916113002: Don't use m32 cflag for x86_64. (Closed) Base URL: https://skia.googlesource.com/skia.git@baselijne
Patch Set: Make desktops distinguish between x86 and x86_64 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # conditions used in both common.gypi and skia.gyp in chromium 1 # conditions used in both common.gypi and skia.gyp in chromium
2 # 2 #
3 { 3 {
4 'defines': [ 4 'defines': [
5 'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)', 5 'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)',
6 'SK_SUPPORT_GPU=<(skia_gpu)', 6 'SK_SUPPORT_GPU=<(skia_gpu)',
7 'SK_SUPPORT_OPENCL=<(skia_opencl)', 7 'SK_SUPPORT_OPENCL=<(skia_opencl)',
8 'SK_FORCE_DISTANCE_FIELD_TEXT=<(skia_force_distance_field_text)', 8 'SK_FORCE_DISTANCE_FIELD_TEXT=<(skia_force_distance_field_text)',
9 ], 9 ],
10 'conditions' : [ 10 'conditions' : [
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 ], 220 ],
221 'cflags_cc': [ 221 'cflags_cc': [
222 '-std=c++11', 222 '-std=c++11',
223 '-fno-rtti', 223 '-fno-rtti',
224 '-Wnon-virtual-dtor', 224 '-Wnon-virtual-dtor',
225 '-Wno-invalid-offsetof', # GCC <4.6 is old-school strict about what i s POD. 225 '-Wno-invalid-offsetof', # GCC <4.6 is old-school strict about what i s POD.
226 ], 226 ],
227 'conditions': [ 227 'conditions': [
228 [ 'skia_os != "chromeos"', { 228 [ 'skia_os != "chromeos"', {
229 'conditions': [ 229 'conditions': [
230 [ 'skia_arch_width == 64 and skia_arch_type == "x86"', { 230 [ 'skia_arch_type == "x86_64"', {
231 'cflags': [ 231 'cflags': [
232 '-m64', 232 '-m64',
233 ], 233 ],
234 'ldflags': [ 234 'ldflags': [
235 '-m64', 235 '-m64',
236 ], 236 ],
237 }], 237 }],
238 [ 'skia_arch_width == 32 and skia_arch_type == "x86"', { 238 [ 'skia_arch_type == "x86"', {
239 'cflags': [ 239 'cflags': [
240 '-m32', 240 '-m32',
241 ], 241 ],
242 'ldflags': [ 242 'ldflags': [
243 '-m32', 243 '-m32',
244 ], 244 ],
245 }], 245 }],
246 ], 246 ],
247 }], 247 }],
248 [ 'skia_warnings_as_errors', { 248 [ 'skia_warnings_as_errors', {
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
621 'cflags': ['-O2'], 621 'cflags': ['-O2'],
622 }, 622 },
623 }, 623 },
624 'libraries': [ 624 'libraries': [
625 '-llog', 625 '-llog',
626 ], 626 ],
627 'cflags': [ 627 'cflags': [
628 '-fuse-ld=gold', 628 '-fuse-ld=gold',
629 ], 629 ],
630 'conditions': [ 630 'conditions': [
631 [ 'skia_arch_type == "x86"', { 631 [ '"x86" in skia_arch_type', {
632 'cflags': [ 632 'cflags': [
633 '-mssse3', 633 '-mssse3',
634 ], 634 ],
635 }], 635 }],
636 [ 'skia_android_framework', { 636 [ 'skia_android_framework', {
637 'cflags!': [ 637 'cflags!': [
638 '-fuse-ld=gold', 638 '-fuse-ld=gold',
639 ], 639 ],
640 }], 640 }],
641 [ 'skia_shared_lib', { 641 [ 'skia_shared_lib', {
(...skipping 20 matching lines...) Expand all
662 [ 'skia_is_bot', { 662 [ 'skia_is_bot', {
663 'defines': [ 'SK_CRASH_HANDLER' ], 663 'defines': [ 'SK_CRASH_HANDLER' ],
664 }], 664 }],
665 665
666 ], # end 'conditions' 666 ], # end 'conditions'
667 # The Xcode SYMROOT must be at the root. See build/common.gypi in chromium for more details 667 # The Xcode SYMROOT must be at the root. See build/common.gypi in chromium for more details
668 'xcode_settings': { 668 'xcode_settings': {
669 'SYMROOT': '<(DEPTH)/xcodebuild', 669 'SYMROOT': '<(DEPTH)/xcodebuild',
670 }, 670 },
671 } 671 }
OLDNEW
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698