Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: gyp/opts.gyp

Issue 916113002: Don't use m32 cflag for x86_64. (Closed) Base URL: https://skia.googlesource.com/skia.git@baselijne
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Gyp file for building opts target.
1 { 2 {
2 # Source lists live in opts.gypi. This makes it easier to maintain our Chrome GYP/GN setup. 3 # Source lists live in opts.gypi. This makes it easier to maintain our Chrome GYP/GN setup.
3 # (To be honest, I'm not sure why we need to include common.gypi. I thought i t was automatic.) 4 # (To be honest, I'm not sure why we need to include common.gypi. I thought i t was automatic.)
4 'variables': { 5 'variables': {
5 'includes': [ 'common.gypi', 'opts.gypi' ], 6 'includes': [ 'common.gypi', 'opts.gypi' ],
6 }, 7 },
7 8
8 # Generally we shove things into one 'opts' target conditioned on platform. 9 # Generally we shove things into one 'opts' target conditioned on platform.
9 # If a particular platform needs some files built with different flags, 10 # If a particular platform needs some files built with different flags,
10 # those become separate targets: opts_ssse3, opts_sse41, opts_neon. 11 # those become separate targets: opts_ssse3, opts_sse41, opts_neon.
11 12
12 'targets': [ 13 'targets': [
13 { 14 {
14 'target_name': 'opts', 15 'target_name': 'opts',
15 'product_name': 'skia_opts', 16 'product_name': 'skia_opts',
16 'type': 'static_library', 17 'type': 'static_library',
17 'standalone_static_library': 1, 18 'standalone_static_library': 1,
18 'dependencies': [ 19 'dependencies': [
19 'core.gyp:*', 20 'core.gyp:*',
20 'effects.gyp:*' 21 'effects.gyp:*'
21 ], 22 ],
22 'include_dirs': [ 23 'include_dirs': [
23 '../src/core', 24 '../src/core',
24 '../src/opts', 25 '../src/opts',
25 '../src/utils', 26 '../src/utils',
26 '../include/utils', 27 '../include/utils',
27 ], 28 ],
28 'conditions': [ 29 'conditions': [
29 [ 'skia_arch_type == "x86" and skia_os != "ios"', { 30 [ '"x86" in skia_arch_type and skia_os != "ios"', {
30 'cflags': [ '-msse2' ], 31 'cflags': [ '-msse2' ],
31 'dependencies': [ 'opts_ssse3', 'opts_sse41' ], 32 'dependencies': [ 'opts_ssse3', 'opts_sse41' ],
32 'sources': [ '<@(sse2_sources)' ], 33 'sources': [ '<@(sse2_sources)' ],
33 }], 34 }],
34 35
35 [ 'skia_arch_type == "mips"', { 36 [ 'skia_arch_type == "mips"', {
36 'conditions': [ 37 'conditions': [
37 [ '(mips_arch_variant == "mips32r2") and (mips_dsp == 1 or mips_dsp == 2)', { 38 [ '(mips_arch_variant == "mips32r2") and (mips_dsp == 1 or mips_dsp == 2)', {
38 'sources': [ '<@(mips_dsp_sources)' ], 39 'sources': [ '<@(mips_dsp_sources)' ],
39 },{ 40 },{
40 'sources': [ '<@(none_sources)' ], 41 'sources': [ '<@(none_sources)' ],
41 }], 42 }],
42 ] 43 ]
43 }], 44 }],
44 45
45 [ '(skia_arch_type == "arm" and arm_version < 7) \ 46 [ '(skia_arch_type == "arm" and arm_version < 7) \
46 or (skia_os == "ios") \ 47 or (skia_os == "ios") \
47 or (skia_os == "android" and skia_arch_type not in ["x86", "arm", "m ips", "arm64"])', { 48 or (skia_os == "android" and skia_arch_type not in ["arm", "mips", " arm64"] and "x86" not in skia_arch_type)', {
mtklein 2015/02/11 18:15:05 seems more straightforward to just write ["arm",
scroggo 2015/02/11 20:12:10 That seems fine to me. Done.
48 'sources': [ '<@(none_sources)' ], 49 'sources': [ '<@(none_sources)' ],
49 }], 50 }],
50 51
51 [ 'skia_arch_type == "arm" and arm_version >= 7', { 52 [ 'skia_arch_type == "arm" and arm_version >= 7', {
52 # The assembly uses the frame pointer register (r7 in Thumb/r11 in 53 # The assembly uses the frame pointer register (r7 in Thumb/r11 in
53 # ARM), the compiler doesn't like that. 54 # ARM), the compiler doesn't like that.
54 'cflags!': [ '-fno-omit-frame-pointer', '-mapcs-frame', '-mapcs' ], 55 'cflags!': [ '-fno-omit-frame-pointer', '-mapcs-frame', '-mapcs' ],
55 'cflags': [ '-fomit-frame-pointer' ], 56 'cflags': [ '-fomit-frame-pointer' ],
56 'variables': { 'arm_neon_optional%': '<(arm_neon_optional>' }, 57 'variables': { 'arm_neon_optional%': '<(arm_neon_optional>' },
57 'sources': [ '<@(armv7_sources)' ], 58 'sources': [ '<@(armv7_sources)' ],
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 ], 149 ],
149 }], 150 }],
150 ], 151 ],
151 'ldflags': [ 152 'ldflags': [
152 '-march=armv7-a', 153 '-march=armv7-a',
153 '-Wl,--fix-cortex-a8', 154 '-Wl,--fix-cortex-a8',
154 ], 155 ],
155 }, 156 },
156 ], 157 ],
157 } 158 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698