Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: gyp/common_variables.gypi

Issue 916113002: Don't use m32 cflag for x86_64. (Closed) Base URL: https://skia.googlesource.com/skia.git@baselijne
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2012 The Android Open Source Project 1 # Copyright 2012 The Android Open Source Project
2 # 2 #
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 { 6 {
7 # Get ready for the ugly... 7 # Get ready for the ugly...
8 # 8 #
9 # - We have to nest our variables dictionaries multiple levels deep, so that 9 # - We have to nest our variables dictionaries multiple levels deep, so that
10 # this and other gyp files can rely on previously-set variable values in 10 # this and other gyp files can rely on previously-set variable values in
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 [ 'skia_os == "win"', { 75 [ 'skia_os == "win"', {
76 'os_posix%': 0, 76 'os_posix%': 0,
77 }, { 77 }, {
78 'os_posix%': 1, 78 'os_posix%': 1,
79 }], 79 }],
80 [ 'skia_os in ["linux"]', { 80 [ 'skia_os in ["linux"]', {
81 'skia_poppler_enabled%': 1, 81 'skia_poppler_enabled%': 1,
82 }, { 82 }, {
83 'skia_poppler_enabled%': 0, 83 'skia_poppler_enabled%': 0,
84 }], 84 }],
85 [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "mac"] or skia_ arch_type == "arm64"', { 85 [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "mac"] or "64" in skia_arch_type', {
mtklein 2015/02/11 18:15:05 So are we going to get "x86" and "x86_64" as skia
scroggo 2015/02/11 20:12:10 I would like it to be the case for all builds (alt
scroggo 2015/02/11 20:15:26 And now of course I'm not sure of that. It appears
scroggo 2015/02/12 15:35:45 I made that change in https://codereview.chromium.
scroggo 2015/02/12 15:55:47 Pulled in that change here. PTAL.
86 'skia_arch_width%': 64, 86 'skia_arch_width%': 64,
87 }, { 87 }, {
88 'skia_arch_width%': 32, 88 'skia_arch_width%': 32,
89 }], 89 }],
90 [ 'skia_os == "android"', { 90 [ 'skia_os == "android"', {
91 'skia_static_initializers%': 0, 91 'skia_static_initializers%': 0,
92 'skia_egl%': 1, 92 'skia_egl%': 1,
93 }, { 93 }, {
94 'skia_static_initializers%': 1, 94 'skia_static_initializers%': 1,
95 }], 95 }],
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 'skia_moz2d%': 0, 238 'skia_moz2d%': 0,
239 'skia_is_bot%': '<!(python -c "import os; print os.environ.get(\'CHROME_HEAD LESS\', 0)")', 239 'skia_is_bot%': '<!(python -c "import os; print os.environ.get(\'CHROME_HEAD LESS\', 0)")',
240 'skia_egl%': '<(skia_egl)', 240 'skia_egl%': '<(skia_egl)',
241 241
242 # These are referenced by our .gypi files that list files (e.g. core.gypi) 242 # These are referenced by our .gypi files that list files (e.g. core.gypi)
243 # 243 #
244 'skia_src_path%': '../src', 244 'skia_src_path%': '../src',
245 'skia_include_path%': '../include', 245 'skia_include_path%': '../include',
246 }, 246 },
247 } 247 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698