chrome/browser/extensions/api/dial/dial_registry.cc - Issue 916103007: Remove DCHECK in DialRegistry dtor. This may trigger on browser shutdown if

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/dial/dial_registry.cc

Issue 916103007: Remove DCHECK in DialRegistry dtor. This may trigger on browser shutdown if (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add TODO Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/dial/dial_registry.cc

diff --git a/chrome/browser/extensions/api/dial/dial_registry.cc b/chrome/browser/extensions/api/dial/dial_registry.cc

index 22d43c06f9b02c812608d352dc013dd656cece39..50f60f2be9e39eead8aa9c149d693b71590d4646 100644

--- a/chrome/browser/extensions/api/dial/dial_registry.cc

+++ b/chrome/browser/extensions/api/dial/dial_registry.cc

@@ -42,7 +42,6 @@ DialRegistry::DialRegistry(Observer* dial_api,

DialRegistry::~DialRegistry() {

DCHECK(thread_checker_.CalledOnValidThread());

- DCHECK_EQ(0, num_listeners_);

NetworkChangeNotifier::RemoveNetworkChangeObserver(this);

}

« chrome/browser/extensions/api/dial/dial_api.h ('K') | « chrome/browser/extensions/api/dial/dial_api.h ('k') | no next file » | no next file with comments »