Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: chrome/browser/extensions/api/dial/dial_api.h

Issue 916103007: Remove DCHECK in DialRegistry dtor. This may trigger on browser shutdown if (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/dial/dial_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/dial/dial_api.h
diff --git a/chrome/browser/extensions/api/dial/dial_api.h b/chrome/browser/extensions/api/dial/dial_api.h
index 6548a72badda55ff325789dbb2d2dc57a300ab4f..eb4bf2b5aba82af8ec4c10f1a01c27d200cccf2b 100644
--- a/chrome/browser/extensions/api/dial/dial_api.h
+++ b/chrome/browser/extensions/api/dial/dial_api.h
@@ -21,6 +21,10 @@ class DialRegistry;
// the DIAL registry. It takes care of creating the registry on the IO thread
// and is an observer of the registry. It makes sure devices events are sent out
// to extension listeners on the right thread.
+//
+// TODO(mfoltz): This should probably inherit from BrowserContextKeyedAPI
+// instead, as there is nothing refcounted on the UI thread we are explicitly
+// managing here; ShutdownOnUIThread below is a no-op.
Wez 2015/02/19 22:48:32 This comment's pretty confusing; are you saying th
class DialAPI : public RefcountedKeyedService,
public EventRouter::Observer,
public DialRegistry::Observer {
« no previous file with comments | « no previous file | chrome/browser/extensions/api/dial/dial_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698