Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 916103007: Remove DCHECK in DialRegistry dtor. This may trigger on browser shutdown if (Closed)

Created:
5 years, 10 months ago by mark a. foltz
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DCHECK in DialRegistry dtor. This may trigger on browser shutdown if there are event listeners still registered with chrome.dial. This is not an issue as all owned objects will be cleaned up anyway by following the normal dtor sequence DialAPI -> DialRegistry -> DialService. BUG=460197 Committed: https://crrev.com/06dc4c4f1e654a1a3a4a30da8ecfe016beb9413b Cr-Commit-Position: refs/heads/master@{#317194}

Patch Set 1 #

Patch Set 2 : Add TODO #

Total comments: 1

Patch Set 3 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/extensions/api/dial/dial_api.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_registry.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
mark a. foltz
5 years, 10 months ago (2015-02-19 20:11:53 UTC) #2
Wez
lgtm https://codereview.chromium.org/916103007/diff/20001/chrome/browser/extensions/api/dial/dial_api.h File chrome/browser/extensions/api/dial/dial_api.h (right): https://codereview.chromium.org/916103007/diff/20001/chrome/browser/extensions/api/dial/dial_api.h#newcode27 chrome/browser/extensions/api/dial/dial_api.h:27: // managing here; ShutdownOnUIThread below is a no-op. ...
5 years, 10 months ago (2015-02-19 22:48:32 UTC) #3
mark a. foltz
On 2015/02/19 22:48:32, Wez wrote: > lgtm > > https://codereview.chromium.org/916103007/diff/20001/chrome/browser/extensions/api/dial/dial_api.h > File chrome/browser/extensions/api/dial/dial_api.h (right): > ...
5 years, 10 months ago (2015-02-19 23:04:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916103007/40001
5 years, 10 months ago (2015-02-19 23:18:30 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-20 00:41:14 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 00:41:42 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/06dc4c4f1e654a1a3a4a30da8ecfe016beb9413b
Cr-Commit-Position: refs/heads/master@{#317194}

Powered by Google App Engine
This is Rietveld 408576698