Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Issue 916103005: Make sweeper threads respect the max_available_threads constraint. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make sweeper threads respect the max_available_threads constraint. BUG= Committed: https://crrev.com/3f5ff276f3d1837b92d1ced0b18253d3968c9c01 Cr-Commit-Position: refs/heads/master@{#27091}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M src/heap/heap.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
ulan
PTAL
5 years, 10 months ago (2015-02-18 12:06:57 UTC) #2
Hannes Payer (out of office)
What is the motivation behind that cl? Note that concurrent sweeping turns into lazy sweeping ...
5 years, 10 months ago (2015-02-19 17:32:56 UTC) #3
ulan
On 2015/02/19 17:32:56, Hannes Payer wrote: > What is the motivation behind that cl? Note ...
5 years, 10 months ago (2015-02-20 09:57:37 UTC) #4
Hannes Payer (out of office)
lgtm
5 years, 10 months ago (2015-02-20 11:53:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916103005/20001
5 years, 10 months ago (2015-02-23 07:12:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/145)
5 years, 10 months ago (2015-02-23 07:13:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/145)
5 years, 10 months ago (2015-02-23 07:13:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916103005/40001
5 years, 9 months ago (2015-03-10 09:29:10 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-10 09:58:22 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 09:58:41 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3f5ff276f3d1837b92d1ced0b18253d3968c9c01
Cr-Commit-Position: refs/heads/master@{#27091}

Powered by Google App Engine
This is Rietveld 408576698