Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: content/browser/renderer_host/input/input_router_impl_unittest.cc

Issue 916103002: Avoid sending touchmove events where all pointers are stationary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert TouchMove acks to NO_CONSUMER_EXISTS. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/input/touch_event_queue.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <math.h> 5 #include <math.h>
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 1284 matching lines...) Expand 10 before | Expand all | Expand 10 after
1295 PressTouchPoint(1, 1); 1295 PressTouchPoint(1, 1);
1296 SendTouchEvent(); 1296 SendTouchEvent();
1297 EXPECT_EQ(1U, GetSentMessageCountAndResetSink()); 1297 EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
1298 1298
1299 // TOUCH_ACTION_NONE should disable the timeout. 1299 // TOUCH_ACTION_NONE should disable the timeout.
1300 OnSetTouchAction(TOUCH_ACTION_NONE); 1300 OnSetTouchAction(TOUCH_ACTION_NONE);
1301 SendInputEventACK(WebInputEvent::TouchStart, INPUT_EVENT_ACK_STATE_CONSUMED); 1301 SendInputEventACK(WebInputEvent::TouchStart, INPUT_EVENT_ACK_STATE_CONSUMED);
1302 EXPECT_EQ(1U, ack_handler_->GetAndResetAckCount()); 1302 EXPECT_EQ(1U, ack_handler_->GetAndResetAckCount());
1303 EXPECT_FALSE(TouchEventTimeoutEnabled()); 1303 EXPECT_FALSE(TouchEventTimeoutEnabled());
1304 1304
1305 MoveTouchPoint(0, 1, 1); 1305 MoveTouchPoint(0, 1, 2);
1306 SendTouchEvent(); 1306 SendTouchEvent();
1307 EXPECT_FALSE(TouchEventTimeoutEnabled()); 1307 EXPECT_FALSE(TouchEventTimeoutEnabled());
1308 EXPECT_EQ(1U, GetSentMessageCountAndResetSink()); 1308 EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
1309 1309
1310 // Delay the move ack. The timeout should not fire. 1310 // Delay the move ack. The timeout should not fire.
1311 RunTasksAndWait(base::TimeDelta::FromMilliseconds(timeout_ms + 1)); 1311 RunTasksAndWait(base::TimeDelta::FromMilliseconds(timeout_ms + 1));
1312 EXPECT_EQ(0U, ack_handler_->GetAndResetAckCount()); 1312 EXPECT_EQ(0U, ack_handler_->GetAndResetAckCount());
1313 EXPECT_EQ(0U, GetSentMessageCountAndResetSink()); 1313 EXPECT_EQ(0U, GetSentMessageCountAndResetSink());
1314 SendInputEventACK(WebInputEvent::TouchEnd, INPUT_EVENT_ACK_STATE_CONSUMED); 1314 SendInputEventACK(WebInputEvent::TouchEnd, INPUT_EVENT_ACK_STATE_CONSUMED);
1315 EXPECT_EQ(1U, ack_handler_->GetAndResetAckCount()); 1315 EXPECT_EQ(1U, ack_handler_->GetAndResetAckCount());
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
1744 client_overscroll = client_->GetAndResetOverscroll(); 1744 client_overscroll = client_->GetAndResetOverscroll();
1745 EXPECT_EQ(wheel_overscroll.accumulated_overscroll, 1745 EXPECT_EQ(wheel_overscroll.accumulated_overscroll,
1746 client_overscroll.accumulated_overscroll); 1746 client_overscroll.accumulated_overscroll);
1747 EXPECT_EQ(wheel_overscroll.latest_overscroll_delta, 1747 EXPECT_EQ(wheel_overscroll.latest_overscroll_delta,
1748 client_overscroll.latest_overscroll_delta); 1748 client_overscroll.latest_overscroll_delta);
1749 EXPECT_EQ(wheel_overscroll.current_fling_velocity, 1749 EXPECT_EQ(wheel_overscroll.current_fling_velocity,
1750 client_overscroll.current_fling_velocity); 1750 client_overscroll.current_fling_velocity);
1751 } 1751 }
1752 1752
1753 } // namespace content 1753 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/renderer_host/input/touch_event_queue.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698