Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 916093003: Intersitial page updates (Closed)

Created:
5 years, 10 months ago by edwardjung
Modified:
5 years, 10 months ago
CC:
arv+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Intersitial page updates + New consistent sized icons. + Fix bug when page zooming in an out on desktop. + Add styling for secondary button for 'Show saved copy' experiment. BUG=456746, 422882 Committed: https://crrev.com/8393ee8bfe69049c4aac3c4b1371efdb002942c7 Cr-Commit-Position: refs/heads/master@{#316225}

Patch Set 1 #

Patch Set 2 : Optimise icons, update secondary button colour #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -23 lines) Patch
M chrome/browser/resources/security_warnings/images/1x/brokenssl_red.png View 1 Binary file 0 comments Download
M chrome/browser/resources/security_warnings/images/1x/captive_portal_page_icon.png View 1 Binary file 0 comments Download
M chrome/browser/resources/security_warnings/images/1x/clock.png View 1 Binary file 0 comments Download
M chrome/browser/resources/security_warnings/images/1x/stop_sign.png View 1 Binary file 0 comments Download
M chrome/browser/resources/security_warnings/images/2x/brokenssl_red.png View 1 Binary file 0 comments Download
M chrome/browser/resources/security_warnings/images/2x/captive_portal_page_icon.png View 1 Binary file 0 comments Download
M chrome/browser/resources/security_warnings/images/2x/clock.png View 1 Binary file 0 comments Download
M chrome/browser/resources/security_warnings/images/2x/stop_sign.png View 1 Binary file 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.css View 1 8 chunks +18 lines, -11 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2_mobile.js View 1 chunk +14 lines, -5 lines 0 comments Download
M chrome/renderer/resources/default_100_percent/common/error_network_generic.png View Binary file 0 comments Download
M chrome/renderer/resources/default_100_percent/offline/100-error-offline.png View Binary file 0 comments Download
M chrome/renderer/resources/default_200_percent/common/error_network_generic.png View Binary file 0 comments Download
M chrome/renderer/resources/default_200_percent/offline/200-error-offline.png View Binary file 0 comments Download
M chrome/renderer/resources/neterror.css View 1 4 chunks +16 lines, -7 lines 0 comments Download
M chrome/renderer/resources/neterror.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
edwardjung
Further updates to the interstitials. Please take a look. Thanks, Edward
5 years, 10 months ago (2015-02-13 12:45:47 UTC) #3
edwardjung
Further updates to the interstitials. Please take a look. Thanks, Edward
5 years, 10 months ago (2015-02-13 12:45:47 UTC) #4
arv (Not doing code reviews)
LGTM
5 years, 10 months ago (2015-02-13 14:27:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916093003/20001
5 years, 10 months ago (2015-02-13 16:10:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 16:32:01 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 16:32:56 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8393ee8bfe69049c4aac3c4b1371efdb002942c7
Cr-Commit-Position: refs/heads/master@{#316225}

Powered by Google App Engine
This is Rietveld 408576698