Add support for compressed GPU memory buffers.

content/common/gpu/gpu_command_buffer_stub.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/hash.h"
 #include "base/json/json_writer.h"
 #include "base/memory/shared_memory.h"
@@ skipping 938 matching lines @@
   if (!decoder_)
     return;
 
   gpu::gles2::ImageManager* image_manager = decoder_->GetImageManager();
   DCHECK(image_manager);
   if (image_manager->LookupImage(id)) {
     LOG(ERROR) << "Image already exists with same ID.";
     return;
   }
 
+  bool supported_format = true;
+
+  gpu::Capabilities capabilities = decoder_->GetCapabilities();
+  switch (format) {
+    case gfx::GpuMemoryBuffer::ATC:
+    case gfx::GpuMemoryBuffer::ATCIA:
+      if (!capabilities.texture_format_atc)
+        supported_format = false;
+      break;
+    case gfx::GpuMemoryBuffer::BGRA_8888:
+      if (!capabilities.texture_format_bgra8888)
+        supported_format = false;
+      break;
+    case gfx::GpuMemoryBuffer::DXT1:
+      if (!capabilities.texture_format_dxt1)
+        supported_format = false;
+      break;
+    case gfx::GpuMemoryBuffer::DXT5:
+      if (!capabilities.texture_format_dxt5)
+        supported_format = false;
+      break;
+    case gfx::GpuMemoryBuffer::ETC1:
+      if (!capabilities.texture_format_etc1)
+        supported_format = false;
+      break;
+    case gfx::GpuMemoryBuffer::RGBA_8888:
+    case gfx::GpuMemoryBuffer::RGBX_8888:
+      break;
+  }

[reveman, 2015/02/13 23:51:25]

Looks good. Can you just move this into a IsSupportedImageFormat helper function
with

NOTREACHED();
return false;

at the end? I think that would be a bit cleaner and we'd also detect if format
was ever an invalid value.

[christiank, 2015/02/18 14:38:25]

Sure! I'll fix this.

+
+  if (!supported_format) {
+    LOG(ERROR) << "Image format is not supported.";
+    return;
+  }
+
   scoped_refptr<gfx::GLImage> image = channel()->CreateImageForGpuMemoryBuffer(
       handle, size, format, internalformat);
   if (!image.get())
     return;
 
   image_manager->AddImage(image.get(), id);
 }
 
 void GpuCommandBufferStub::OnDestroyImage(int32 id) {
   TRACE_EVENT0("gpu", "GpuCommandBufferStub::OnDestroyImage");
@@ skipping 108 matching lines @@
 uint64 GpuCommandBufferStub::GetMemoryUsage() const {
   return GetMemoryManager()->GetClientMemoryUsage(this);
 }
 
 void GpuCommandBufferStub::SwapBuffersCompleted(
     const std::vector<ui::LatencyInfo>& latency_info) {
   Send(new GpuCommandBufferMsg_SwapBuffersCompleted(route_id_, latency_info));
 }
 
 }  // namespace content