Issue 916033002: Oilpan: Move LifecycleNotifier's hierarchy to Oilpan's heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 916033002: Oilpan: Move LifecycleNotifier's hierarchy to Oilpan's heap

Created:
5 years, 10 months ago by haraken

Modified:
5 years, 10 months ago

Reviewers:

CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, pfeldman+blink_chromium.org, malch+blink_chromium.org, eustas+blink_chromium.org, sof, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, loislo+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: Move LifecycleNotifier's hierarchy to Oilpan's heap BUG=340522

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -51 lines)			Patch
M	Source/bindings/core/v8/V8ScriptRunner.cpp	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/dom/ActiveDOMObject.cpp	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/dom/ContextLifecycleNotifier.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/core/dom/ContextLifecycleNotifier.cpp	View	6 chunks	+33 lines, -0 lines	0 comments	Download
M	Source/core/dom/DocumentLifecycleNotifier.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/core/dom/DocumentLifecycleNotifier.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/dom/ExecutionContext.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/ExecutionContext.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/frame/DOMWindowLifecycleNotifier.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/core/frame/DOMWindowLifecycleNotifier.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/inspector/AsyncCallTracker.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/PageLifecycleNotifier.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/core/page/PageLifecycleNotifier.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/modules/webmidi/MIDIAccessInitializer.cpp	View	2 chunks	+0 lines, -16 lines	0 comments	Download
M	Source/platform/LifecycleContextTest.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/platform/LifecycleNotifier.h	View	7 chunks	+22 lines, -6 lines	0 comments	Download
M	Source/platform/LifecycleObserver.h	View	3 chunks	+1 line, -12 lines	0 comments	Download
M	Source/platform/Supplementable.h	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

haraken

5 years, 10 months ago (2015-02-11 10:51:28 UTC) #1

Not yet for review.

This still crashes a bunch of webkit_unit_tests.

Expand Messages | Collapse Messages