Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 916003002: Fix a crash for ppb_pdf_impl.cc under single process model (Closed)

Created:
5 years, 10 months ago by jinlong.zhai
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash for ppb_pdf_impl.cc under single process model In PPB_PDF_Impl::SetPrintClient where CHECK(!g_print_client) may fail under --single-process model, since code here is to expect there to be only one g_print_client instance within a render process(thread). But --single-process model will create all RenderThread in a single process, thus g_print_client may be created many times in a single process and CHECK(!g_print_client) will fail. In this patch we will change g_print_client from process-level to RenderThread-level, since every render process will only keep one RenderThread. BUG=457580 Committed: https://crrev.com/1251f5f51de3d611c74535883f8263b3283eca69 Cr-Commit-Position: refs/heads/master@{#316422}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a comment and and reference #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M components/pdf/renderer/ppb_pdf_impl.cc View 1 4 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jinlong.zhai
Please help to look at this patch. Thanks, Jinlong
5 years, 10 months ago (2015-02-11 09:40:04 UTC) #2
dmichael (off chromium)
lgtm https://codereview.chromium.org/916003002/diff/1/components/pdf/renderer/ppb_pdf_impl.cc File components/pdf/renderer/ppb_pdf_impl.cc (right): https://codereview.chromium.org/916003002/diff/1/components/pdf/renderer/ppb_pdf_impl.cc#newcode41 components/pdf/renderer/ppb_pdf_impl.cc:41: g_print_client_tls = LAZY_INSTANCE_INITIALIZER; Please add a comment briefly ...
5 years, 10 months ago (2015-02-11 17:35:00 UTC) #3
jinlong.zhai
hi, dmichael I have added a comment and reference the bug. Please take a look ...
5 years, 10 months ago (2015-02-15 07:40:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916003002/40001
5 years, 10 months ago (2015-02-16 01:35:22 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-16 02:28:36 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 02:29:10 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1251f5f51de3d611c74535883f8263b3283eca69
Cr-Commit-Position: refs/heads/master@{#316422}

Powered by Google App Engine
This is Rietveld 408576698