Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 915973002: Add bookmark apps to taskbar automatically. (Closed)

Created:
5 years, 10 months ago by benwells
Modified:
5 years, 10 months ago
Reviewers:
jackhou1
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add bookmark apps to taskbar automatically. The code to do this was present but broken. Now the code works on Windows. BUG=456650 Committed: https://crrev.com/a0e8eaaed65690d95e2b97aff2369c8a969bbacf Cr-Commit-Position: refs/heads/master@{#316162}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Feedback #

Patch Set 3 : Mac compile #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -14 lines) Patch
M chrome/browser/extensions/bookmark_app_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.cc View 1 2 3 2 chunks +20 lines, -11 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
benwells
5 years, 10 months ago (2015-02-11 06:18:48 UTC) #2
jackhou1
https://codereview.chromium.org/915973002/diff/1/chrome/browser/web_applications/web_app.cc File chrome/browser/web_applications/web_app.cc (right): https://codereview.chromium.org/915973002/diff/1/chrome/browser/web_applications/web_app.cc#newcode286 chrome/browser/web_applications/web_app.cc:286: bool ShouldCreateShortcutFor(web_app::ShortcutCreationReason reason, Need to update the use of ...
5 years, 10 months ago (2015-02-11 07:14:42 UTC) #3
benwells
https://codereview.chromium.org/915973002/diff/1/chrome/browser/web_applications/web_app.cc File chrome/browser/web_applications/web_app.cc (right): https://codereview.chromium.org/915973002/diff/1/chrome/browser/web_applications/web_app.cc#newcode286 chrome/browser/web_applications/web_app.cc:286: bool ShouldCreateShortcutFor(web_app::ShortcutCreationReason reason, On 2015/02/11 07:14:42, jackhou1 wrote: > ...
5 years, 10 months ago (2015-02-12 02:09:36 UTC) #4
jackhou1
lgtm
5 years, 10 months ago (2015-02-12 04:57:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915973002/20001
5 years, 10 months ago (2015-02-12 04:58:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/23159)
5 years, 10 months ago (2015-02-12 05:24:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915973002/40001
5 years, 10 months ago (2015-02-12 23:37:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/33804)
5 years, 10 months ago (2015-02-13 01:28:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915973002/60001
5 years, 10 months ago (2015-02-13 02:46:04 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-13 04:32:34 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 04:33:13 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a0e8eaaed65690d95e2b97aff2369c8a969bbacf
Cr-Commit-Position: refs/heads/master@{#316162}

Powered by Google App Engine
This is Rietveld 408576698