Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 915963002: [vim] Add ninja-powered CrBuild/CrCompileFile functions. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[vim] Add ninja-powered CrBuild/CrCompileFile functions. These are based on the ninja-build.vim file found in Chromium, adapted to V8, and enhanced with goma support (automatically increase job limit for ninja if goma is detected). Committed: https://crrev.com/b10d55fd34320ed2c6d42836192dbca004b22734 Cr-Commit-Position: refs/heads/master@{#26563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -0 lines) Patch
A tools/vim/ninja-build.vim View 1 chunk +119 lines, -0 lines 0 comments Download
A tools/vim/ninja_output.py View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
5 years, 10 months ago (2015-02-11 06:47:45 UTC) #2
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-11 06:56:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915963002/1
5 years, 10 months ago (2015-02-11 06:57:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 06:59:08 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 06:59:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b10d55fd34320ed2c6d42836192dbca004b22734
Cr-Commit-Position: refs/heads/master@{#26563}

Powered by Google App Engine
This is Rietveld 408576698