mojo/public/cpp/environment/tests/logging_unittest.cc - Issue 915953002: Fix LoggingTest.Dcheck in release DCHECK_ALWAYS_ON builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/environment/tests/logging_unittest.cc

Issue 915953002: Fix LoggingTest.Dcheck in release DCHECK_ALWAYS_ON builds. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/environment/tests/logging_unittest.cc

diff --git a/mojo/public/cpp/environment/tests/logging_unittest.cc b/mojo/public/cpp/environment/tests/logging_unittest.cc

index 53a1f8850416757335535719507d47d8b0c3af86..7ecc8b2080a6ef099d2599d77e628c7daa747e31 100644

--- a/mojo/public/cpp/environment/tests/logging_unittest.cc

+++ b/mojo/public/cpp/environment/tests/logging_unittest.cc

@@ -451,7 +451,7 @@ TEST_F(LoggingTest, Dcheck) {

// fails to compile the condition.)

bool was_called = false;

MOJO_DCHECK(DcheckTestHelper(&was_called)) << "hello";

-#ifdef NDEBUG

+#if defined(NDEBUG) && !defined(DCHECK_ALWAYS_ON)

EXPECT_FALSE(was_called);

EXPECT_FALSE(log_message_was_called());

#else

« no previous file with comments | « no previous file | no next file » | no next file with comments »