Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 915953002: Fix LoggingTest.Dcheck in release DCHECK_ALWAYS_ON builds. (Closed)

Created:
5 years, 10 months ago by viettrungluu
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix LoggingTest.Dcheck in release DCHECK_ALWAYS_ON builds. One wonders if anything is ever tested, ever. TBR=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e9827c5507b1c0435f8a4e9987ff5bd044b21ac9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/cpp/environment/tests/logging_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 10 months ago (2015-02-11 05:45:47 UTC) #1
viettrungluu
Committed patchset #1 (id:1) manually as e9827c5507b1c0435f8a4e9987ff5bd044b21ac9 (presubmit successful).
5 years, 10 months ago (2015-02-11 05:46:08 UTC) #2
jamesr
5 years, 10 months ago (2015-02-11 05:48:42 UTC) #3
Message was sent while issue was closed.
Huh, what was this doing?

lgtm

Powered by Google App Engine
This is Rietveld 408576698